Skip to content

Update Travis to clang-format 8#1898

Merged
dberzano merged 2 commits intoAliceO2Group:devfrom
awegrzyn:update-cf-8
Apr 17, 2019
Merged

Update Travis to clang-format 8#1898
dberzano merged 2 commits intoAliceO2Group:devfrom
awegrzyn:update-cf-8

Conversation

@awegrzyn
Copy link
Copy Markdown
Contributor

No description provided.

@awegrzyn awegrzyn requested a review from dberzano April 17, 2019 08:47
@dberzano
Copy link
Copy Markdown
Contributor

E: Unable to locate package clang-format-8 (otherwise it's fine for me to do the upgrade)

@sawenzel
Copy link
Copy Markdown
Collaborator

Can you remind me why this is necessary and where the user gets this from locally?

@dberzano
Copy link
Copy Markdown
Contributor

@sawenzel there was a discussion with no objections last week at WP3 (see minutes); the rationale was that clang-format-7 still has "some problems" with our code, but I honestly don't know the details. No problem in putting this on hold until tomorrow if you need clarifications from the stakeholders.

About getting this locally, if using Ubuntu I believe you can just have a look at the Travis CI recipe (add an apt source and then install clang-format-8).

@sawenzel
Copy link
Copy Markdown
Collaborator

Agreed but it would be useful to know the problems and if they are actually solved by bumping.

@ktf
Copy link
Copy Markdown
Member

ktf commented Apr 17, 2019

One of the problem is that when having:

auto [foo, _] = somethingWhichReturnsAPairReference();

the auto [foo, _] is misunderstood as an array and formatted as auto[foo,_].

@sawenzel
Copy link
Copy Markdown
Collaborator

Fair enough.

@dberzano
Copy link
Copy Markdown
Contributor

OK thanks for clarifying. Merging.

@dberzano dberzano merged commit b789fb8 into AliceO2Group:dev Apr 17, 2019
@awegrzyn awegrzyn deleted the update-cf-8 branch April 17, 2019 11:37
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Apr 15, 2023
…uts (AliceO2Group#1898)

* [PWGLF] LightNucleiTask - Fix TPC cuts

* [PWGLF] LightNucleiTask - Add calibration friendly mode and new TPC cuts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants