bug fix in interaction sampler for event time jitter#1601
Merged
ktf merged 2 commits intoAliceO2Group:devfrom Jan 18, 2019
Merged
bug fix in interaction sampler for event time jitter#1601ktf merged 2 commits intoAliceO2Group:devfrom
ktf merged 2 commits intoAliceO2Group:devfrom
Conversation
Collaborator
|
Thanks @noferini for fixing my bug! |
Collaborator
Author
|
I and chiara already tested it. |
Collaborator
|
Ciao @ktf , The format check did not pass (a space was missing). We were about to correct it. Should we fix it in a new PR? Chiara |
Member
|
Please do. Could you also add a unit test for it so that we test it in the build? |
Member
|
forget about it... I understood something different... |
mikesas
pushed a commit
to mikesas/AliceO2
that referenced
this pull request
Dec 13, 2022
* Cleanup + histo fixes * Fix momentum conservation check * Fix for linter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRandom->Gaus(mTimeBCRMS) invoked in the wrong way (1 argument has to be the mean and not the RMS). RMS moved as second argument