Conversation
There was a problem hiding this comment.
Not sure about your comment. The free-function pointer is required by FairMQDevice::NewMessageFor. Agreed, using FreeFn of Stack for this purpose is probably awkward, but since you added the function that should be fully valid. now. What do you think should be removed?
There was a problem hiding this comment.
DPLmerger - remove or fix somehow, that code never had a chance of working - they use a std::vector and just pass the pointer to the first element with the free function. A proper fix (using a std::vector with a pmr allocator) is contained in #1514 of which this PR is a subset - I'll make a new PR that contains the fix. Of course there are other ways of fixing it :)
There was a problem hiding this comment.
@matthiasrichter the proper fix is in #1593 , depends on this PR
There was a problem hiding this comment.
very good, thanks
* Create propagatorQa.cxx * Update CMakeLists.txt * Please consider the following formatting changes * re-trigger checks... * Extra whitepace removal * Bugfix * Please consider the following formatting changes Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
2 participants
this largely is cleanup, also addresses codechecker warnings related to Stack.