Skip to content

Support skipping invalid timeframes across parent files - #15797

Open
autumn-mck wants to merge 1 commit into
AliceO2Group:devfrom
autumn-mck:parents-skipping
Open

autumn-mck wants to merge 1 commit into
AliceO2Group:devfrom
autumn-mck:parents-skipping

Conversation

@autumn-mck

Copy link
Copy Markdown
Contributor

No description provided.

@autumn-mck
autumn-mck requested a review from a team as a code owner September 15, 2026 11:52
Comment on lines +380 to +381
throw InvalidAODReadError(fmt::format(R"(while looking for tree "{}", the parent file was requested but we are already at level {} of maximal allowed level {} for DF "{}" in file "{}")", treename.c_str(), mLevel, mContext.allowedParentLevel, folderName.c_str(),
rootFS->GetFile()->GetName()));

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to remain a run time error as it is a configuration mistake. We shouldn't put these in fault tolerance.


void DataInputDescriptor::reportFileStatistics(int counter, std::string monitoringInfo)
{
monitoringInfo += fmt::format(",read_df={},skipped_df={}", getReadTimeFramesInFile(counter), mfilenames.at(counter).invalidReadSkipped);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please grep the Hyperloop code and *.java on alimonitor if we somewhere rely on the order. I hope not...

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 36c9bb1 at 2026-09-15 22:26:

## sw/BUILD/O2-full-system-test-latest/log
command o2-sim --field=ccdb --vertexMode kCollContext --seed 12345 -n 5 --configKeyValues "Diamond.width[2]=6.;GenTPCLoopers.colsys=PbPb;" -g pythia8hi -e TGeant4 -j 24 --run 310000 -o o2sim --fromCollContext collisioncontext.root:o2sim had nonzero exit code 1
[ERROR] SHUTTING DOWN DUE TO SIGNALED EXIT IN COMPONENT 649
[22:25:02][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
[22:25:02][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/Users/m/mgiacalo/WGAN_ExtGenPair for 1789503897619 (agent_id: o2-sim-primary-/o2-sim-primary-server-device-runner@627 target/Linux_x86_64 init/1789503897049 id/mesosci@alimetal01.cern.ch session/FcGzC2Gn) with http code: 0
[22:25:02][ERROR] File Users/m/mgiacalo/WGAN_ExtGenPair could not be retrieved. No more hosts to try.
[22:25:02][ERROR] Unable to find object Users/m/mgiacalo/WGAN_ExtGenPair/1789503897619, Aborting
[22:25:02][FATAL] Error: issues in retrieving Users/m/mgiacalo/WGAN_ExtGenPair from CCDB!
[22:26:04][ERROR] No configuration received within 60000ms
[22:26:05][ERROR] Could not initialize simulation


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/bcca0d767be953c0fad10df29efc99a77d1daf90/slc9_x86-64/o2checkcode/1.0-local17/etc/modulefiles
++ alibuild-generate-module
+ HAS_BIN=
+ HAS_LIB=
+ HAS_CMAKE=
+ HAS_ROOT=
+ '[' 0 '!=' 0 ']'
+ cat
+ printf 'if ![ is-loaded '\''BASE/1.0'\'' ] {\n module load BASE/1.0\n}'
+ echo 'BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release'
BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release
+ FULL_BUILD_REQUIRES='ninja-fortran ninja FairCMakeModules UUID googlebenchmark safe_int Python-modules-list MPFR json-c pytorch_cpuinfo date CMake O2-customization defaults-release Alice-GRID-Utils double-conversion bz2 alibuild-recipe-tools'
+ echo 'FULL_BUILD_REQUIRES=ninja-fortran ninja FairCMakeModules UUID googlebenchmark safe_int Python-modules-list MPFR json-c pytorch_cpuinfo date CMake O2-customization defaults-release Alice-GRID-Utils double-conversion bz2 alibuild-recipe-tools'
FULL_BUILD_REQUIRES=ninja-fortran ninja FairCMakeModules UUID googlebenchmark safe_int Python-modules-list MPFR json-c pytorch_cpuinfo date CMake O2-customization defaults-release Alice-GRID-Utils double-conversion bz2 alibuild-recipe-tools
++ env
++ cut -f1 -d=
++ grep -v '^DEFAULT_'
++ grep -v PKGREVISION
++ grep -v ALIBUILD_RECIPE_TOOLS
++ grep REVISION
++ sed -e s/_REVISION//
+ for x in $(env | cut -f1 -d= | grep -v "^DEFAULT_" | grep -v PKGREVISION | grep -v ALIBUILD_RECIPE_TOOLS | grep REVISION | sed -e 's/_REVISION//')
++ eval 'echo $LIBFFI_REVISION'
+++ echo 14
+ REVISION_VALUE=14
++ eval 'echo $LIBFFI_VERSION'
+++ echo v3.2.1-alice1
+ VERSION_VALUE=v3.2.1-alice1
++ eval 'echo $LIBFFI_ROOT'
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants