Support skipping invalid timeframes across parent files - #15797
Open
autumn-mck wants to merge 1 commit into
Open
autumn-mck wants to merge 1 commit into
autumn-mck wants to merge 1 commit into
Conversation
jgrosseo
reviewed
Sep 15, 2026
Comment on lines
+380
to
+381
| throw InvalidAODReadError(fmt::format(R"(while looking for tree "{}", the parent file was requested but we are already at level {} of maximal allowed level {} for DF "{}" in file "{}")", treename.c_str(), mLevel, mContext.allowedParentLevel, folderName.c_str(), | ||
| rootFS->GetFile()->GetName())); |
Collaborator
There was a problem hiding this comment.
This needs to remain a run time error as it is a configuration mistake. We shouldn't put these in fault tolerance.
jgrosseo
reviewed
Sep 15, 2026
|
|
||
| void DataInputDescriptor::reportFileStatistics(int counter, std::string monitoringInfo) | ||
| { | ||
| monitoringInfo += fmt::format(",read_df={},skipped_df={}", getReadTimeFramesInFile(counter), mfilenames.at(counter).invalidReadSkipped); |
Collaborator
There was a problem hiding this comment.
Please grep the Hyperloop code and *.java on alimonitor if we somewhere rely on the order. I hope not...
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 36c9bb1 at 2026-09-15 22:26: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.