[EMCAL-688] Improve ClusterFactory evalDispersion function and fix bug in buildCluster - #15788
Draft
mhemmer-cern wants to merge 1 commit into
Draft
mhemmer-cern wants to merge 1 commit into
mhemmer-cern wants to merge 1 commit into
Conversation
mhemmer-cern
force-pushed
the
EMCAL-688
branch
from
September 11, 2026 15:40
1869dfa to
e9b0125
Compare
mhemmer-cern
added a commit
to mhemmer-cern/AliceO2
that referenced
this pull request
Sep 11, 2026
Please consider the following formatting changes to AliceO2Group#15788
mhemmer-cern
force-pushed
the
EMCAL-688
branch
from
September 11, 2026 21:33
f06c21d to
a6968b6
Compare
mhemmer-cern
force-pushed
the
EMCAL-688
branch
from
September 11, 2026 21:35
a6968b6 to
9d15d37
Compare
mhemmer-cern
marked this pull request as ready for review
September 11, 2026 22:32
Contributor
Author
|
macOS-arm build seems to fail due to something unrelated to this PR |
mhemmer-cern
changed the title
evalDispersion function
mhemmer-cern
changed the title
evalDispersion functionevalDispersion function
mhemmer-cern
marked this pull request as draft
September 13, 2026 20:38
Contributor
Author
|
Running over larger number of local files showed some weird outliers in the dispersion distribution. I will take another look again. Might be connected to clusters going over SM boundaries. |
- Remove TMath calls with std function calls - Fix wrong comments for `thetaToEta` and `etaToTheta` in the .cxx - `buildCluster` uses the local index of cells in eta and phi for calcualting M02, M20 and dispersion. The member `mSharedCluster` would need to be set to true, to apply a correction for the local index when switching from one SM to antoher for cluster spanning two SM. This commit fixes this issue by setting `mSharedCluster` in `buildCluster`. - Add `mCellGeomBuffer` as new member which stores the geometry information of all cells of the current cluster. This way this information is only obtained ONCE instead of THREE times. - Removed unused unary operator& which can be dangerous.
mhemmer-cern
force-pushed
the
EMCAL-688
branch
from
September 14, 2026 13:53
9d15d37 to
85923f0
Compare
Contributor
Author
Indeed it was broken. Should be fixed now with this PR. |
mhemmer-cern
changed the title
evalDispersion functionevalDispersion function and fix bug in buildCluster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildClusteruses the local index of cells in eta and phi for calcualting M02, M20 and dispersion. The membermSharedClusterwould need to be set to true, to apply a correction for the local index when switching from one SM to antoher for cluster spanning two SM. This commit fixes this issue by settingmSharedClusterinbuildCluster.thetaToEtaandetaToThetain the .cxxmCellGeomBufferas new member which stores the geometry information of all cells of the current cluster. This way this information is only obtained ONCE instead of THREE times.