dev: creating decoding method which can be used also in QC ctp#11271
dev: creating decoding method which can be used also in QC ctp#11271shahor02 merged 4 commits intoAliceO2Group:devfrom
Conversation
|
The decoding function itself is fine but using RawDecoderSpec as an include for other processor is not good, may mess up dependencies. It is better to put it into a separate class, even as having only this static method. |
|
@shahor02 : thanks. I'll create new class. In workflow or in reconstruction ? |
|
I would put it in the reconstruction, with all framework classes forward declared in the header and included in the implementation. |
|
Hi @shahor02 , created separate class. Please, have a look. |
|
@shahor02 build/O2/o2-dataflow failed. But I can not see any CTP related error ? |
Detectors/CTP/reconstruction/include/CTPReconstruction/RawDataDecoder.h
Outdated
Show resolved
Hide resolved
| void setVerbose(bool v) { mVerbose = v; } | ||
| uint32_t getIRRejected() { return mIRRejected; } | ||
| uint32_t getTCRRejected() { return mTCRRejected; } | ||
| std::vector<uint32_t> getTFOrbits() { return mTFOrbits; } |
There was a problem hiding this comment.
Here you return a copy of the vector but as far as I can see you never modify it. I guess it can be
const std::vector<uint32_t>& getTFOrbits() const { return mTFOrbits; }
| { | ||
| std::sort(mTFOrbits.begin(), mTFOrbits.end()); | ||
| size_t l = mTFOrbits.size(); | ||
| std::vector<uint32_t> TFOrbits = mDecoder.getTFOrbits(); |
There was a problem hiding this comment.
if you change the getTFOrbits() in the way I've suggested, then here there should be
const auto& TFOrbits = mDecoder.getTFOrbits();
There was a problem hiding this comment.
but I modify TFOrbits in the line 36 ?
There was a problem hiding this comment.
OK, did not notice the sort. But then before it was applied to the copy rather than to the data member. No it is ok.
There was a problem hiding this comment.
yes, I understand, thanks.
|
Hi @shahor02 , this can be merged ? |
|
@lietava it says |
|
I do not see anything on my web interface . I solved conflict yesterday - see commits - last merge ? |
|
|
|
I pushed by force. Now I have conflict: |
|
I resolve the conflict now. |
|
Conflict resolved. |
|
sorry, I didnt see this |
…O2Group#11271) * dev: creating decoding method which can be used also in QC ctp * dev: decoding moved to separate class * clang * fix: Ruben's fixes
2 participants
Hi @shahor02 , we are doing code for CTP QC. I realised that it would be useful to have function in decoding which can be used also in:
https://github.com/AliceO2Group/QualityControl/blob/master/Modules/CTP/src/RawDataQcTask.cxx
Do you see any problem with that ?
Any other comments ?
Cheers, R.