Fix codechecker violations

davidrohr · davidrohr · commit 978902f2741d · 2019-12-30T11:50:02.000+01:00
diff --git a/DataFormats/MemoryResources/include/MemoryResources/MemoryResources.h b/DataFormats/MemoryResources/include/MemoryResources/MemoryResources.h
@@ -163,7 +163,7 @@ class SpectatorMemoryResource : public boost::container::pmr::memory_resource
   {
     if (p == mPointer) {
       mBuffer.reset();
-      mPointer = 0;
+      mPointer = nullptr;
     } else if (mPointer == nullptr) {
       // there is an error in the logic flow, this should never be called more than once
       throw std::logic_error("underlying controlled resource has been released already");
diff --git a/run/O2SimDeviceRunner.cxx b/run/O2SimDeviceRunner.cxx
@@ -23,7 +23,7 @@
 #include <sys/wait.h>
 #include <pthread.h> // to set cpu affinity
 #include <cmath>
-#include <signal.h>
+#include <csignal>
 #include <unistd.h>
 
 #include "rapidjson/document.h"

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ class SpectatorMemoryResource : public boost::container::pmr::memory_resource`
`163`	`163`	`{`
`164`	`164`	`if (p == mPointer) {`
`165`	`165`	`mBuffer.reset();`
`166`		`- mPointer = 0;`
	`166`	`+ mPointer = nullptr;`
`167`	`167`	`} else if (mPointer == nullptr) {`
`168`	`168`	`// there is an error in the logic flow, this should never be called more than once`
`169`	`169`	`throw std::logic_error("underlying controlled resource has been released already");`