Fixed #9042 (Another using BOOL type breach) (cppcheck-opensource#1765)

IOBYTE · danmar · commit 22f01f035c59 · 2019-03-27T21:42:50.000+01:00
diff --git a/lib/tokenize.cpp b/lib/tokenize.cpp
@@ -1899,6 +1899,7 @@ bool Tokenizer::simplifyUsing()
             }
             if (tok == endOfTemplateDefinition) {
                 inTemplateDefinition = false;
+                endOfTemplateDefinition = nullptr;
                 continue;
             }
         }
@@ -2127,7 +2128,6 @@ bool Tokenizer::simplifyUsing()
                             str += " ;";
                             std::list<const Token *> callstack(1, usingStart);
                             mErrorLogger->reportErr(ErrorLogger::ErrorMessage(callstack, &list, Severity::debug, "debug",
-
                                                     "Failed to parse \'" + str + "\'. The checking continues anyway.", false));
                         }
                     }
@@ -2148,7 +2148,7 @@ bool Tokenizer::simplifyUsing()
             if (usingEnd->next())
                 Token::eraseTokens(usingStart->previous(), usingEnd->next());
             else {
-                Token::eraseTokens(usingStart, usingEnd);
+                Token::eraseTokens(usingStart->previous(), usingEnd);
                 usingEnd->deleteThis();
             }
         } else {
diff --git a/test/testpostfixoperator.cpp b/test/testpostfixoperator.cpp
@@ -173,6 +173,16 @@ class TestPostfixOperator : public TestFixture {
               "}");
         ASSERT_EQUALS("", errout.str());
 
+        // #9042
+        check("template <class T>\n"
+              "class c {\n"
+              "    int i = 0;\n"
+              "    c() { i--; }\n"
+              "};\n"
+              "template <class T>\n"
+              "class s {};\n"
+              "using BOOL = char;");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void testfor() {
diff --git a/test/testsimplifyusing.cpp b/test/testsimplifyusing.cpp
@@ -63,6 +63,7 @@ class TestSimplifyUsing : public TestFixture {
         TEST_CASE(simplifyUsing8971);
         TEST_CASE(simplifyUsing8976);
         TEST_CASE(simplifyUsing9040);
+        TEST_CASE(simplifyUsing9042);
     }
 
     std::string tok(const char code[], bool simplify = true, Settings::PlatformType type = Settings::Native, bool debugwarnings = true) {
@@ -474,6 +475,27 @@ class TestSimplifyUsing : public TestFixture {
         ASSERT_EQUALS(exp, tok(code, true, Settings::Win64));
     }
 
+    void simplifyUsing9042() {
+        const char code[] = "template <class T>\n"
+                            "class c {\n"
+                            "    int i = 0;\n"
+                            "    c() { i--; }\n"
+                            "};\n"
+                            "template <class T>\n"
+                            "class s {};\n"
+                            "using BOOL = char;";
+
+        const char exp[] = "template < class T > "
+                           "class c { "
+                           "int i ; i = 0 ; "
+                           "c ( ) { i -- ; } "
+                           "} ; "
+                           "template < class T > "
+                           "class s { } ;";
+
+        ASSERT_EQUALS(exp, tok(code, true, Settings::Win64));
+    }
+
 };
 
 REGISTER_TEST(TestSimplifyUsing)

Original file line number	Diff line number	Diff line change
`@@ -1899,6 +1899,7 @@ bool Tokenizer::simplifyUsing()`
`1899`	`1899`	`}`
`1900`	`1900`	`if (tok == endOfTemplateDefinition) {`
`1901`	`1901`	`inTemplateDefinition = false;`
	`1902`	`+ endOfTemplateDefinition = nullptr;`
`1902`	`1903`	`continue;`
`1903`	`1904`	`}`
`1904`	`1905`	`}`
`@@ -2127,7 +2128,6 @@ bool Tokenizer::simplifyUsing()`
`2127`	`2128`	`str += " ;";`
`2128`	`2129`	`std::list<const Token *> callstack(1, usingStart);`
`2129`	`2130`	`mErrorLogger->reportErr(ErrorLogger::ErrorMessage(callstack, &list, Severity::debug, "debug",`
`2130`		`-`
`2131`	`2131`	`"Failed to parse \'" + str + "\'. The checking continues anyway.", false));`
`2132`	`2132`	`}`
`2133`	`2133`	`}`
`@@ -2148,7 +2148,7 @@ bool Tokenizer::simplifyUsing()`
`2148`	`2148`	`if (usingEnd->next())`
`2149`	`2149`	`Token::eraseTokens(usingStart->previous(), usingEnd->next());`
`2150`	`2150`	`else {`
`2151`		`- Token::eraseTokens(usingStart, usingEnd);`
	`2151`	`+ Token::eraseTokens(usingStart->previous(), usingEnd);`
`2152`	`2152`	`usingEnd->deleteThis();`
`2153`	`2153`	`}`
`2154`	`2154`	`} else {`