Skip to content

feat: Ollama Pull #290

Open
navneettoppo wants to merge 2 commits into
AlexsJones:mainfrom
navneettoppo:ollama-pull
Open

feat: Ollama Pull #290
navneettoppo wants to merge 2 commits into
AlexsJones:mainfrom
navneettoppo:ollama-pull

Conversation

@navneettoppo
Copy link
Copy Markdown

@navneettoppo navneettoppo commented Mar 24, 2026

added an Ollama Pull popup in the TUI, accessible with the O key

now you directly pull any LLM which is listing in the LLMFIT

image image

@AlexsJones
Copy link
Copy Markdown
Owner

I believe this is covered in the current download system?

@three-foxes-in-a-trenchcoat
Copy link
Copy Markdown
Collaborator

Good addition, Ram. The Ollama pull popup is a nice UX improvement.

Verdict: LGTM

A couple of minor notes:

  • The ollama_pull_base snapshot captures the full model list on open. If someone has hundreds of models, this could get slow. Worth adding a limit or pagination down the line, but fine for now.
  • Nice touch marking installed models with ✓ in the suggestion list.

Clean code, well-structured. Good to merge.

@three-foxes-in-a-trenchcoat
Copy link
Copy Markdown
Collaborator

Nice feature — the Ollama pull popup fills a real gap. The real-time search filtering and existing-model checkmarks are nice UX touches. One note: you added the which crate as a dependency for the providers.rs file. If it was previously used via std::env::var checks, make sure this is actually needed or consider keeping it optional. Otherwise, clean feature.

@three-foxes-in-a-trenchcoat
Copy link
Copy Markdown
Collaborator

Nice feature! The Ollama pull popup is a handy addition. A few observations:

  1. The which crate dependency is a bit heavy for just checking Ollama availability - consider Command::new("ollama").output() with a simple Err check.
  2. O key is a good choice avoiding conflicts.
  3. The popup currently only shows models from the local llmfit database, not the full Ollama library - worth considering an "add custom model" option.

@AlexsJones
Copy link
Copy Markdown
Owner

Hey thanks, have you seen the new download section? I don't see a huge deal of value add in this, but maybe you can explain your vision?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature. The Ollama pull popup fills a real gap with real-time search filtering and existing-model checkmarks. The which crate dependency is reasonable for cross-platform binary detection. LGTM - ready to merge once the branch resolves its dirty state.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Verdict: Approve

Adds Ollama Pull functionality to the TUI. The changes are focused and well-structured:

  • tui_app.rs: adds pull dialog and state management
  • tui_events.rs: handles keyboard events for pull
  • tui_ui.rs: adds UI components for the pull flow
  • providers.rs: adds Ollama model fetching

The feature is useful and the implementation looks clean. CI checks are passing.

One suggestion: consider adding a confirmation step before pulling to prevent accidental downloads. But the existing PR already has a download confirmation (based on the CHANGELOG).

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants