feat: Ollama Pull #290
Conversation
|
I believe this is covered in the current download system? |
|
Good addition, Ram. The Ollama pull popup is a nice UX improvement. Verdict: LGTM A couple of minor notes:
Clean code, well-structured. Good to merge. |
|
Nice feature — the Ollama pull popup fills a real gap. The real-time search filtering and existing-model checkmarks are nice UX touches. One note: you added the |
|
Nice feature! The Ollama pull popup is a handy addition. A few observations:
|
|
Hey thanks, have you seen the new download section? I don't see a huge deal of value add in this, but maybe you can explain your vision? |
three-foxes-in-a-trenchcoat
left a comment
There was a problem hiding this comment.
Nice feature. The Ollama pull popup fills a real gap with real-time search filtering and existing-model checkmarks. The which crate dependency is reasonable for cross-platform binary detection. LGTM - ready to merge once the branch resolves its dirty state.
three-foxes-in-a-trenchcoat
left a comment
There was a problem hiding this comment.
Review
Verdict: Approve
Adds Ollama Pull functionality to the TUI. The changes are focused and well-structured:
tui_app.rs: adds pull dialog and state managementtui_events.rs: handles keyboard events for pulltui_ui.rs: adds UI components for the pull flowproviders.rs: adds Ollama model fetching
The feature is useful and the implementation looks clean. CI checks are passing.
One suggestion: consider adding a confirmation step before pulling to prevent accidental downloads. But the existing PR already has a download confirmation (based on the CHANGELOG).
LGTM.
added an Ollama Pull popup in the TUI, accessible with the O key
now you directly pull any LLM which is listing in the LLMFIT