lesson3. Устранение недостатков

AlbertoJava · AlbertoJava · commit 75b14bc2bc81 · 2019-07-30T22:47:09.000+03:00
почему ты не используешь Ctrl + Alt + L

SortedArrayStorage
resumeCounter-index-1
resumeCounter-indexResume
indexResume+1
indexResume=-index - 1
не пишем мы слитно (edited)
- в методе update
срабатывает это условие
if (index &lt; 0) {
           System.out.println("ERROR: resume with UUID = " + resume.getUuid() + " didn't found. Resume can't be updated.");
       }
и резюме все равно обновляется
diff --git a/src/com/urise/webapp/storage/AbstractArrayStorage.java b/src/com/urise/webapp/storage/AbstractArrayStorage.java
@@ -64,6 +64,7 @@ public void update(Resume resume) {
         int index = getIndex(resume.getUuid());
         if (index < 0) {
             System.out.println("ERROR: resume with UUID = " + resume.getUuid() + " didn't found. Resume can't be updated.");
+            return;
         }
         storage[index] = resume;
     }
diff --git a/src/com/urise/webapp/storage/SortedArrayStorage.java b/src/com/urise/webapp/storage/SortedArrayStorage.java
@@ -14,14 +14,14 @@ protected int getIndex(String uuid) {
 
     @Override
     protected void insertResume(int index, Resume resume) {
-        int indexResume=-index - 1;
-        System.arraycopy(storage, indexResume, storage, indexResume+1, resumeCounter-indexResume);
+        int indexResume = -index - 1;
+        System.arraycopy(storage, indexResume, storage, indexResume + 1, resumeCounter - indexResume);
         storage[indexResume] = resume;
     }
 
     @Override
     protected void deleteResume(int index) {
-        System.arraycopy(storage, index + 1, storage, index, resumeCounter-index-1);
+        System.arraycopy(storage, index + 1, storage, index, resumeCounter - index - 1);
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,7 @@ public void update(Resume resume) {`
`64`	`64`	`int index = getIndex(resume.getUuid());`
`65`	`65`	`if (index < 0) {`
`66`	`66`	`System.out.println("ERROR: resume with UUID = " + resume.getUuid() + " didn't found. Resume can't be updated.");`
	`67`	`+ return;`
`67`	`68`	`}`
`68`	`69`	`storage[index] = resume;`
`69`	`70`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,14 +14,14 @@ protected int getIndex(String uuid) {`
`14`	`14`
`15`	`15`	`@Override`
`16`	`16`	`protected void insertResume(int index, Resume resume) {`
`17`		`- int indexResume=-index - 1;`
`18`		`- System.arraycopy(storage, indexResume, storage, indexResume+1, resumeCounter-indexResume);`
	`17`	`+ int indexResume = -index - 1;`
	`18`	`+ System.arraycopy(storage, indexResume, storage, indexResume + 1, resumeCounter - indexResume);`
`19`	`19`	`storage[indexResume] = resume;`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`@Override`
`23`	`23`	`protected void deleteResume(int index) {`
`24`		`- System.arraycopy(storage, index + 1, storage, index, resumeCounter-index-1);`
	`24`	`+ System.arraycopy(storage, index + 1, storage, index, resumeCounter - index - 1);`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`}`