Search: Preserve IME composition in controlled inputs - #534
Open
aioya wants to merge 1 commit into
Open
Conversation
👷 Deploy request for telegram-tt-previews pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The chat message search uses an experimental controlled input. During Chinese IME composition, each intermediate
inputevent can restore the DOM value from the previous renderedvalue. This interrupts the active composition and leaves partial Latin letters before a candidate can be selected.Fix
Treat the delegated input event as an
InputEventand skip controlled-value restoration whileisComposingis true. Input callbacks still run during composition, and normal controlled-value restoration resumes after the IME commits or cancels the composition.This is implemented in the shared controlled-input layer so other IME-backed controlled inputs receive the same behavior.
Checks
./node_modules/.bin/tsc --pretty falsenpx eslint src/lib/teact/teact-dom.tsgit diff --checkCloses #533