Conversation
Without this the socket timeout code fails to compile
…IOError in Python2
icanhasmath
left a comment
icanhasmath
left a comment
There was a problem hiding this comment.
Socket should be available in python2 : https://docs.python.org/2.7/library/socket.html
|
The problem is, Socket has to support being a resource ie "using", and I don't believe it does in Python2, from the failures I was getting. |
I need to look into it again, I believe that was the Enum problem I was having. |
rickprice
force-pushed
the
BE-3126-cve-2023-40217
branch
2 times, most recently
from
4eb7f15 to
5d88718
Compare
I'm not sure now, maybe we should put it back in? Ah, so the problem was that they are using an Enum to list the available versions of SSL, and Python2 just doesn't have Enums in core. If we wanted this, we would have to rewrite stuff to use something other than an Enum. I think that's possible. |
rickprice
force-pushed
the
BE-3126-cve-2023-40217
branch
from
5d88718 to
d0fee9c
Compare
icanhasmath
left a comment
icanhasmath
left a comment
There was a problem hiding this comment.
Looks good - Tested consistently.
2 participants
Fixes for CVE-2023-40217