Greptile Summary

This PR fixes a filename mismatch in the terminal backup/restore flow. The backup operation always created aterm_backup.tar, but the restore path was reading from aterm_backup.bin (in Terminal.js) and the settings UI was copying into and cleaning up a file named aterm_backup / aterm_backup.bin — meaning restore was completely broken. All three references are now aligned to aterm_backup.tar.

Additionally, the backup EXCLUDE list is extended with Android-specific bind-mount directories (apex, odm, product, system_ext, linkerconfig) and Linux virtual filesystems (proc, sys, dev, run, tmp), which prevents those transient/virtual paths from inflating or corrupting a PRoot backup archive.

Key changes:

• Terminal.js restore(): aterm_backup.bin → aterm_backup.tar (core bug fix)
• terminalSettings.js terminalRestore(): copy target and cleanup filename corrected to aterm_backup.tar
• File picker MIME type broadened from application/x-tar to application/octet-stream
• A stale inline comment (atem_backup.bin) was not updated alongside the code fix

Confidence Score: 5/5

Safe to merge — fixes a clear filename mismatch that made restore completely non-functional; remaining findings are minor style issues.

The core bug (.bin vs .tar mismatch) is correctly fixed across all three callsites. The additional EXCLUDE entries are conservative and correct. The only open items are a stale comment and a style note about the MIME type breadth — neither blocks functionality.

No files require special attention beyond the stale comment at src/settings/terminalSettings.js:331.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A([User: Backup]) --> B[FileBrowser: pick folder]
    B --> C[Terminal.backup]
    C --> D{Alpine installed?}
    D -- No --> E[reject: Alpine not installed]
    D -- Yes --> F["tar -cf $PREFIX/aterm_backup.tar\n(with EXCLUDE dirs)"]
    F --> G{result == 'ok'?}
    G -- No --> H[reject with output]
    G -- Yes --> I[copyToUri → user folder as aterm_backup.tar]
    I --> J([Backup complete])

    K([User: Restore]) --> L["sdcard.openDocumentFile\n(MIME: application/octet-stream)"]
    L --> M["copyToUri → cordova.file.dataDirectory/aterm_backup.tar"]
    M --> N[Terminal.restore]
    N --> O[Stop AXS if running]
    O --> P[Delete existing alpine/axs/…]
    P --> Q["tar -xf $PREFIX/aterm_backup.tar -C $PREFIX"]
    Q --> R{result == 'ok'?}
    R -- No --> S[reject with output]
    R -- Yes --> T[delete temp aterm_backup.tar]
    T --> U([Restore complete])

_{Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." | Re-trigger Greptile}