Skip to content

catch exception in apijson, log and return error json #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TommyLemon merged 1 commit into from
Feb 25, 2019
Merged

catch exception in apijson, log and return error json #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 77 additions & 46 deletions uliweb_apijson/apijson/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,22 @@ def apply_vars(self):
self.rdict[key[:-1]] = v

def get(self):
for key in self.request_data:
if key[-1]=="@":
#vars need to be applied later
pass
elif key[-2:]=="[]":
rsp = self._get_array(key)
else:
rsp = self._get_one(key)
if rsp: return rsp
self.apply_vars()
try:
for key in self.request_data:
if key[-1]=="@":
#vars need to be applied later
pass
elif key[-2:]=="[]":
rsp = self._get_array(key)
else:
rsp = self._get_one(key)
if rsp: return rsp
self.apply_vars()
except Exception as e:
err = "exception when handling 'apijson get': %s"%(e)
log.error(err)
traceback.print_exc()
return json({"code":400,"msg":err})
return json(self.rdict)

def _get_one(self,key):
Expand Down Expand Up @@ -258,9 +264,15 @@ def _filter_owner(self,model,model_setting,q):
return owner_filtered,q

def head(self):
for key in self.request_data:
rsp = self._head(key)
if rsp: return rsp
try:
for key in self.request_data:
rsp = self._head(key)
if rsp: return rsp
except Exception as e:
err = "exception when handling 'apijson head': %s"%(e)
log.error(err)
traceback.print_exc()
return json({"code":400,"msg":err})

return json(self.rdict)

Expand Down Expand Up @@ -321,17 +333,24 @@ def _head(self,key):
self.rdict[key] = rdict

def post(self):
tag = self.request_data.get("@tag")
if not tag:
return json({"code":400,"msg":"'tag' parameter is needed"})
for key in self.request_data:
if key[0]!="@":
rsp = self._post_one(key,tag)
if rsp:
return rsp
else:
#only accept one table
return json(self.rdict)
try:
tag = self.request_data.get("@tag")
if not tag:
return json({"code":400,"msg":"'tag' parameter is needed"})
for key in self.request_data:
if key[0]!="@":
rsp = self._post_one(key,tag)
if rsp:
return rsp
else:
#only accept one table
return json(self.rdict)
except Exception as e:
err = "exception when handling 'apijson post': %s"%(e)
log.error(err)
traceback.print_exc()
return json({"code":400,"msg":err})

return json(self.rdict)

def _post_one(self,key,tag):
Expand Down Expand Up @@ -423,17 +442,23 @@ def _post_one(self,key,tag):
self.rdict[key] = obj_dict

def put(self):
tag = self.request_data.get("@tag")
if not tag:
return json({"code":400,"msg":"'tag' parameter is needed"})
for key in self.request_data:
if key[0]!="@":
rsp = self._put_one(key,tag)
if rsp:
return rsp
else:
#only accept one table
return json(self.rdict)
try:
tag = self.request_data.get("@tag")
if not tag:
return json({"code":400,"msg":"'tag' parameter is needed"})
for key in self.request_data:
if key[0]!="@":
rsp = self._put_one(key,tag)
if rsp:
return rsp
else:
#only accept one table
return json(self.rdict)
except Exception as e:
err = "exception when handling 'apijson put': %s"%(e)
log.error(err)
traceback.print_exc()
return json({"code":400,"msg":err})

return json(self.rdict)

Expand Down Expand Up @@ -527,17 +552,23 @@ def _put_one(self,key,tag):
self.rdict[key] = obj_dict

def delete(self):
tag = self.request_data.get("@tag")
if not tag:
return json({"code":400,"msg":"'tag' parameter is needed"})
for key in self.request_data:
if key[0]!="@":
rsp = self._delete_one(key,tag)
if rsp:
return rsp
else:
#only accept one table
return json(self.rdict)
try:
tag = self.request_data.get("@tag")
if not tag:
return json({"code":400,"msg":"'tag' parameter is needed"})
for key in self.request_data:
if key[0]!="@":
rsp = self._delete_one(key,tag)
if rsp:
return rsp
else:
#only accept one table
return json(self.rdict)
except Exception as e:
err = "exception when handling 'apijson delete': %s"%(e)
log.error(err)
traceback.print_exc()
return json({"code":400,"msg":err})
return json(self.rdict)

def _delete_one(self,key,tag):
Expand Down