This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Feature/wk web view fixes#4647
Open
tushar-TH wants to merge 5 commits into
Open
Conversation
Replaced dispatch_barrier_async with dispatch_barrier_sync
Also updated in TestCases.
| } | ||
| } | ||
| }]; | ||
| __strong __typeof(weakSelf) strongSelf = weakSelf; |
There was a problem hiding this comment.
Why have you put the strongSelf declaration out of the block?
Author
There was a problem hiding this comment.
if 'typeof(self)' does include or imply the attribute, it must mean __strong, so your usual declaration was necessarily __strong.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UIWebView Related changes fixes.
Issue Link 🔗
Goals ⚽
Implementation Details 🚧
Testing Details 🔍