Dev#1614
Merged
Merged
Conversation
Introduce AAOptionsListVC (header & implementation) and register it in the Xcode project.pbxproj. Move the AAOptions / DrawChartWithAAOptions entry into its own list VC and remove the previous inline handling from MainVC, adjusting subsequent case indices and the section list accordingly. Improve AABaseListVC: only set default title when empty and split cell title strings on '---' to populate titleLabel and subtitleLabel (trimmed subtitle support). These changes organize AAOptions routes and improve table cell presentation.
Refactor AAOptions menu by moving several AAOptions submenus out of MainVC and into AAOptionsListVC. Added imports and new section entries (Pie, Polar, Multi Y axes, PlotLines/Bands/Zones, Areaspline, Tooltip, DataLabels, X/Y axis labels/types) and expanded chartTypeTitleArr. Implemented a section-based switch in tableView:didSelectRowAtIndexPath to push the appropriate option view controller. Cleaned up MainVC by removing related imports, removed the old per-section cases and renumbered remaining cases. This consolidates AAOptions routing into AAOptionsListVC for clearer structure and simpler MainVC.
Uncomment AAOptionsListVC import and wire AAOptions into the tab/sidebar. Replace the second view controller to use AAOptionsListVC with a title and system chart icon. Introduce createFourthViewController (AAOptionsWithJSForChartEventsListVC, titled "AAOptions JS") and createFourthNavigationController, and add the fourth navigation controller to the viewControllers and navigationControllers arrays. These changes expose both AAOptions and AAOptions JS tabs in the sidebar and fix view controller ordering.
Add new AAOptionsWithJSListVC (header + implementation) to group JS-function demo items. Update AAChartKitDemo.xcodeproj to include the new files and build entries. Modify AppDelegate to import and use AAOptionsWithJSListVC as the third tab (custom tab item) and swap MainVC into the fourth tab. Update MainVC to remove direct JS demo pushes, adjust case indices and menu arrays to reflect the new dedicated JS options list and reflowed section indexes.
Introduce OfficialSamplesListVC (header + implementation) to present official chart samples (Area, Bar/Column, Pie) using new AAOfficialSamplesChartVC which supplies AAOptions from various composer classes. Add the new files to the Xcode project file. Update AppDelegate to import the new controller, register it as the fourth tab, and add a fifth MainVC tab by adding createFifthViewController/createFifthNavigationController and including them in the sidebar/navigation setup. This exposes official sample charts in the demo app and integrates the new view controllers into the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.