Dev#1609
Merged
Merged
Conversation
Introduced 'dashedAxisAndCustomAxisTitlePositionLineChart2' example to demonstrate a line chart with dashed axes and custom axis title positions. Updated chart and axis documentation comments and added the new chart to the demo list.
Replaces hardcoded axis line colors with dynamic placeholders for X and Y axes, allowing for easier customization. JavaScript function strings are updated to use these placeholders, which are replaced with actual color values before execution.
Changed xAxis color to red and yAxis color to green. Removed asynchronous JavaScript execution block for setting axis colors.
Replaced AAJSFunc macro usage with direct string concatenation for the JavaScript function in dashedAxisAndCustomAxisTitlePositionLineChart2. This simplifies the code and improves readability.
Simplified the JavaScript function string color replacement logic by using string formatting instead of manual placeholder replacement for axis colors in dashedAxisAndCustomAxisTitlePositionLineChart2.
Added .clipSet(false) to both series elements to disable clipping. Also reformatted NSString stringWithFormat usage for improved readability.
Moved AAAxisTitle class and related constants from AAYAxis.h/m to new dedicated files AAAxisTitle.h/m for better modularity and maintainability. Updated imports and project configuration to reference the new files.
Introduced textAlign and useHTML properties to AAAxisTitle for enhanced axis title customization. Also updated the align property type to AAChartAxisTitleAlignValueType for better type safety.
Added a comment with the Highcharts xAxis.title.align API reference URL to AAChartAxisTitle.h for improved documentation and clarity.
Moved AAJsonConverter class from AAChartView files into its own AAJsonConverter.h and AAJsonConverter.m files. Updated imports and project configuration to reference the new files, improving code organization and maintainability.
Added the AAJsonConverter import to AAChartKit.h to ensure its functionality is available throughout the module.
…roperty serialization logic Simplifies property extraction by removing superclass traversal and improves error handling in JSON serialization methods. Debug logging is now conditional, and nil value handling is streamlined for better performance and readability.
AAOptionsConfigurationGenerator now inherits from NSObject instead of AAJsonConverter. Also, the method now returns nil instead of calling dictionaryWithObjectInstance, which is commented out.
Introduces JSFunctionBeforeAndAfterRenderingComposer7 for demonstrating custom alignment of scrollable plot area masks using JavaScript in Highcharts. Updates the view controller to use this new example and registers the new composer files in the Xcode project.
Eliminated extensive console logging from the customScrollablePlotAreaMask plugin JavaScript for cleaner production code. Refined the mask alignment logic to use x-axis line thickness for more accurate mask positioning, and updated xAxis configuration to explicitly set line width and color.
Enhanced the Highcharts scrollablePlotArea mask alignment plugin to ensure the mask fully covers the X axis line and aligns with the plot area edges. Added detailed comments, improved coordinate calculations, and clarified the plugin logic for better maintainability and accuracy. Also refactored chart configuration and test data generation for clarity.
Refactored the Highcharts scrollablePlotArea mask alignment plugin using ES6+ syntax for improved performance and readability. Enhanced DOM query caching, reduced unnecessary calculations, and ensured the mask avoids covering long X-axis labels. Updated demo data to use longer category labels and adjusted axis color and title configuration for better testing of mask coverage.
Expanded file comments with comprehensive debugging guidance for Safari Console, WKWebView, and Highcharts plugin issues. Added technical summaries and troubleshooting steps to assist future maintenance and development.
Expanded and clarified troubleshooting comments for Safari Console logging, regex issues in @AAJSFunc macro, SVG mask rendering, and stroke width handling. Added more detailed solutions and updated technical summary for better developer guidance.
Added AADetailLog statements to output _beforeDrawChartJavaScript and _afterDrawChartJavaScript for debugging. Both variables are now set to nil after execution to prevent repeated calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.