Repository navigation
test(compiler): cover unsigned shifts and notZero at runtime - #1114
Merged
andorthehood merged 1 commit intoOct 22, 2026
Merged
Conversation
Add TestRuntime fixtures and compile-result snapshots for unsigned right shifts and notZero across integer, float32 and float64 values. Exercise sign-bit handling, shift-count masking, signed zeros and a tiny float64 value.
irimias57
added
contributor
compiler
irimias57
approved these changes
Oct 22, 2026
irimias57
left a comment
irimias57
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution, @jinchuntan! The 17 native assertions cover both issues' requirements, including unsigned shift behavior and integer, float32, and float64 notZero results. I found no actionable issues. All 371 compiler tests and the package type check passed locally without updating snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1110.
Closes #1112.
Adds native TestRuntime fixtures and compile-result snapshots for both instructions.
shiftRightUnsigned: positive shifts, zero, sign-bit handling and shift-count masking.notZero: zero and nonzero integers, float32 and float64 values, including negative zero and a tiny float64 value. All expected results are integer0or1.Validated on Node 24.16.0:
All 371 compiler tests passed, including the 17 new native assertions.