device: allow a non-ACPI soft power button - #7953
Merged
Merged
Conversation
lemondrops
requested changes
Sep 14, 2026
Contributor
|
I don't see the point of multiple separate "power off" options: just one generic "soft power off" button that does ACPI/APM/PC Convertible/whatever method depending on the machine should be enough, and "hard power off" is equivalent to exiting 86Box. |
JoshRodd
force-pushed
the
feat/device-soft-power-button
branch
from
September 14, 2026 15:19
9c3fc1a to
e8173a0
Compare
JoshRodd
added a commit
to JoshRodd/86Box-contributions
that referenced
this pull request
Sep 14, 2026
Add the IBM PC Convertible (5140) machine: board, power controller, LCD controller with the optional external CRT adapter, and the controller and firmware compatibility work the original BIOS requires. The LCD presents the controller's binary 640x200 output through per-panel sRGB endpoints and a 20 ms-per-frame liquid-crystal response model, and the three panel variants are selectable. Panel coordinates, RAM and peripheral behaviour follow the February 1986 Technical Reference. This branch is stacked on the open CPU (86Box#7949) and power-button (86Box#7953) contributions and should be merged after them.
JoshRodd
added a commit
to JoshRodd/86Box-contributions
that referenced
this pull request
Sep 14, 2026
Add the IBM PC Convertible (5140) machine: board, power controller, LCD controller with the optional external CRT adapter, and the controller and firmware compatibility work the original BIOS requires. The LCD presents the controller's binary 640x200 output through per-panel sRGB endpoints and a 20 ms-per-frame liquid-crystal response model, and the three panel variants are selectable. Panel coordinates, RAM and peripheral behaviour follow the February 1986 Technical Reference. This branch is stacked on the open CPU (86Box#7949) and power-button (86Box#7953) contributions and should be merged after them.
lemondrops
requested changes
Sep 14, 2026
JoshRodd
added a commit
to JoshRodd/86Box-contributions
that referenced
this pull request
Sep 14, 2026
At this point, we will be removing "ACPI Power Button" verbage and simply offer up a soft power button. The button does whatever the machine does with a soft power button: typically it's wired up to either ACPI or some kind of laptop/portable computer's proprietary ROM BIOS.
Route the existing power action through ACPI when available, otherwise through a registered device callback, and treat a hard power off as exiting 86Box rather than a separate action. No existing machine is opted in. per 86Box#7953 lemondrop's suggestion to remove ACPI verbage At this point, we will be removing "ACPI Power Button" verbage and simply offer up a soft power button. The button does whatever the machine does with a soft power button: typically it's wired up to either ACPI or some kind of laptop/portable computer's proprietary ROM BIOS.
JoshRodd
force-pushed
the
feat/device-soft-power-button
branch
from
September 14, 2026 16:00
0987300 to
c9ea706
Compare
JoshRodd
added a commit
to JoshRodd/86Box-contributions
that referenced
this pull request
Sep 14, 2026
Add the IBM PC Convertible (5140) machine: board, power controller, LCD controller with the optional external CRT adapter, and the controller and firmware compatibility work the original BIOS requires. The LCD presents the controller's binary 640x200 output through per-panel sRGB endpoints and a 20 ms-per-frame liquid-crystal response model, and the three panel variants are selectable. Panel coordinates, RAM and peripheral behaviour follow the February 1986 Technical Reference. This branch is stacked on the open CPU (86Box#7949) and power-button (86Box#7953) contributions and should be merged after them.
JoshRodd
added a commit
to JoshRodd/86Box-contributions
that referenced
this pull request
Sep 14, 2026
Add the IBM PC Convertible (5140) machine: board, power controller, LCD controller with the optional external CRT adapter, and the controller and firmware compatibility work the original BIOS requires. The LCD presents the controller's binary 640x200 output through per-panel sRGB endpoints and a 20 ms-per-frame liquid-crystal response model, and the three panel variants are selectable. Panel coordinates, RAM and peripheral behaviour follow the February 1986 Technical Reference. This branch is stacked on the open CPU (86Box#7949) and power-button (86Box#7953) contributions and should be merged after them.
lemondrops
approved these changes
Sep 14, 2026
JoshRodd
added a commit
to JoshRodd/86Box-contributions
that referenced
this pull request
Sep 14, 2026
Add the IBM PC Convertible (5140) machine: board, power controller, LCD controller with the optional external CRT adapter, and the controller and firmware compatibility work the original BIOS requires. The LCD presents the controller's binary 640x200 output through per-panel sRGB endpoints and a 20 ms-per-frame liquid-crystal response model, and the three panel variants are selectable. Panel coordinates, RAM and peripheral behaviour follow the February 1986 Technical Reference. This branch is stacked on the open CPU (86Box#7949) and power-button (86Box#7953) contributions and should be merged after them.
JoshRodd
added a commit
to JoshRodd/86Box-contributions
that referenced
this pull request
Sep 14, 2026
Add the IBM PC Convertible (5140) machine: board, power controller, LCD controller with the optional external CRT adapter, and the controller and firmware compatibility work the original BIOS requires. The LCD presents the controller's binary 640x200 output through per-panel sRGB endpoints and a 20 ms-per-frame liquid-crystal response model, and the three panel variants are selectable. Panel coordinates, RAM and peripheral behaviour follow the February 1986 Technical Reference. This branch is stacked on the open CPU (86Box#7949) and power-button (86Box#7953) contributions and should be merged after them.
JoshRodd
added a commit
to JoshRodd/86Box-contributions
that referenced
this pull request
Sep 14, 2026
Add the IBM PC Convertible (5140) machine: board, power controller, LCD controller with the optional external CRT adapter, and the controller and firmware compatibility work the original BIOS requires. The LCD presents the controller's binary 640x200 output through per-panel sRGB endpoints and a 20 ms-per-frame liquid-crystal response model, and the three panel variants are selectable. Panel coordinates, RAM and peripheral behaviour follow the February 1986 Technical Reference. This branch is stacked on the open CPU (86Box#7949) and power-button (86Box#7953) contributions and should be merged after them.
JoshRodd
added a commit
to JoshRodd/86Box-contributions
that referenced
this pull request
Sep 14, 2026
Add the IBM PC Convertible (5140) machine: board, power controller, LCD controller with the optional external CRT adapter, and the controller and firmware compatibility work the original BIOS requires. The LCD presents the controller's binary 640x200 output through per-panel sRGB endpoints and a 20 ms-per-frame liquid-crystal response model, and the three panel variants are selectable. Panel coordinates, RAM and peripheral behaviour follow the February 1986 Technical Reference. This branch is stacked on the open CPU (86Box#7949) and power-button (86Box#7953) contributions and should be merged after them.
JoshRodd
added a commit
to JoshRodd/86Box-contributions
that referenced
this pull request
Sep 14, 2026
Add the IBM PC Convertible (5140) machine: board, power controller, LCD controller with the optional external CRT adapter, and the controller and firmware compatibility work the original BIOS requires. The LCD presents the controller's binary 640x200 output through per-panel sRGB endpoints and a 20 ms-per-frame liquid-crystal response model, and the three panel variants are selectable. Panel coordinates, RAM and peripheral behaviour follow the February 1986 Technical Reference. This branch is stacked on the open CPU (86Box#7949) and power-button (86Box#7953) contributions and should be merged after them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current soft power button is ACPI only. This adds a non-ACPI option for non-ACPI machines, such as the IBM PC Convertible.
This doesn't make any changes to any existing machines, but is necessary for future IBM PC Convertible (model 5140) support.
Checklist
References
None used.