Eliminate WP_HTML_Tag_Processor in favor of DOMDocument for assertEqualMarkup#73
Merged
westonruter merged 2 commits intofeature/enhance-wp-scripts-api-with-a-loading-strategyfrom Jun 8, 2023
Conversation
westonruter
changed the title
WP_HTML_Tag_Processor in favor of DOMDocument for assertMarkupEquals
joemcgill
approved these changes
Jun 8, 2023
Collaborator
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
Nice! This is fixes the tests for me locally, is much simpler and removes the dependency on the WP_HTML_Tag_Processor. All good things!
westonruter
merged commit 5ae3a5b
into
feature/enhance-wp-scripts-api-with-a-loading-strategy
1 task
westonruter
changed the title
WP_HTML_Tag_Processor in favor of DOMDocument for assertMarkupEqualsWP_HTML_Tag_Processor in favor of DOMDocument for assertEqualMarkup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amends WordPress#4391
See WordPress/gutenberg#51275 (comment)