Skip to content

Set the default DRY_RUN to false - #127

Merged
jeffpaul merged 1 commit into
10up:developfrom
mukeshpanchal27:fix/126-set-dry-run-false
May 8, 2023
Merged

jeffpaul merged 1 commit into
10up:developfrom
mukeshpanchal27:fix/126-set-dry-run-false

Conversation

@mukeshpanchal27

@mukeshpanchal27 mukeshpanchal27 commented Apr 28, 2023 •

Copy link
Copy Markdown
Contributor

The follow-up changes that were missed in #122 In this PR, set the default value for DRY_RUN to false.

Closes #126

Credits

Props @mukeshpanchal27, @joemcgill, @felixarntz, @aaemnnosttv, @stephywells

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@mukeshpanchal27
mukeshpanchal27 marked this pull request as ready for review April 28, 2023 05:31
@mukeshpanchal27
mukeshpanchal27 requested a review from a team as a code owner April 28, 2023 05:31
@mukeshpanchal27 mukeshpanchal27 self-assigned this Apr 28, 2023
@mukeshpanchal27 mukeshpanchal27 added the needs:code-review This requires code review. label Apr 28, 2023
@mukeshpanchal27 mukeshpanchal27 added this to the 2.2.0 milestone Apr 28, 2023

@joemcgill joemcgill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates look correct to me. Thanks @mukeshpanchal27!

@jeffpaul
jeffpaul merged commit 981693f into 10up:develop May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:code-review This requires code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dry run is on by default

3 participants