Skip to content

Refresh features on save - #4275

Merged
felipeelia merged 18 commits into
developfrom
fix/stale-interface-feature-dependency
Apr 21, 2026
Merged

Refresh features on save#4275
felipeelia merged 18 commits into
developfrom
fix/stale-interface-feature-dependency

Conversation

@ZacharyRener

@ZacharyRener ZacharyRener commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description of the Change

The purpose with this PR is to refresh the feature settings and settings schema on save, instead of requiring a refresh, universally. No changes to EP labs or any feature needed

Closes #4267

How to test the Change

  • Enable Semantic Search
  • Enable a semantic search algorithm version
  • Save settings
  • Go to Instant Results
  • Confirm it is now showing as disabled without refreshing the page

Changelog Entry

Changed - Saving feature settings will now reflect feature dependency without refreshing the page

Credits

Props @ZacharyRener

Checklist:

@ZacharyRener
ZacharyRener marked this pull request as ready for review January 26, 2026 17:16
@ZacharyRener ZacharyRener mentioned this pull request Jan 26, 2026
Closed
1 task done
felipeelia
felipeelia requested changes Jan 27, 2026
View reviewed changes

@felipeelia felipeelia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZacharyRener any chance we can add some e2e tests for this one? Enabling Did you mean should make an option in Instant Results editable, for example.

@ZacharyRener

ZacharyRener commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator Author

@felipeelia The staleness issue happens when the TEMPORARILY_DISABLED status is passed (or similar server side check), because those server side checks weren't applying until page refresh. The did you mean / instant results example you already doesn't go stale because it's just an interface check

EP labs example

So I setup a test plugin here to simulate the conflict and added an e2e test

I'll move this to review once the tests are all passing but just fyi.

@felipeelia felipeelia added this to the 5.3.3 milestone Feb 12, 2026
@ZacharyRener

ZacharyRener commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

The purpose with this PR now is to refresh the feature settings and settings schema on save, instead of requiring a refresh, universally. The test here was updated to be a more generic replication of the issue instead of the temporarily_disabled check from earlier.

For SemanticSearch in particular, EP Labs needs an update to actually consider whether the feature is active before adding the algorithms: 10up/ElasticPressLabs#184

@ZacharyRener ZacharyRener mentioned this pull request Feb 26, 2026
Closed
4 tasks done
@ZacharyRener

ZacharyRener commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator Author

@felipeelia I have a good solution in place now. Just a matter of getting tests passing now

@felipeelia
felipeelia merged commit 9e8f62f into develop Apr 21, 2026
38 checks passed
@felipeelia
felipeelia deleted the fix/stale-interface-feature-dependency branch April 21, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felipeelia felipeelia felipeelia requested changes
@burhandodhy burhandodhy Awaiting requested review from burhandodhy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.3.3

Development

Successfully merging this pull request may close these issues.

Reload settings panel on save

3 participants

@ZacharyRener @felipeelia @anjulahettige