Skip to content

[Facets] Incorrect link on filter blocks - #3997

Merged
felipeelia merged 2 commits into
developfrom
fix/issue-3915
Nov 7, 2024
Merged

felipeelia merged 2 commits into
developfrom
fix/issue-3915

Conversation

@felipeelia

Copy link
Copy Markdown
Member

Description of the Change

This PR isolates the ternary operator, so PHP evaluates wp_is_block_theme() instead of '<p>' . wp_is_block_theme() (which would always return true.

Closes #3915

How to test the Change

Changelog Entry

Fixed - [Facets] Incorrect link on description when not using a block theme

Credits

Props @felipeelia @burhandodhy

Checklist:

@felipeelia felipeelia added this to the 5.2.0 milestone Nov 7, 2024

@burhandodhy burhandodhy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@felipeelia
felipeelia merged commit 9769a5b into develop Nov 7, 2024
@felipeelia
felipeelia deleted the fix/issue-3915 branch November 7, 2024 14:58
@felipeelia felipeelia modified the milestones: 5.2.0, 5.1.4 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Incorrect link on filter blocks

2 participants