diff options
| author | Alper Ak <alperyasinak1@gmail.com> | 2025-12-26 15:09:27 +0300 |
|---|---|---|
| committer | Jarkko Sakkinen <jarkko@kernel.org> | 2026-02-03 02:36:32 +0200 |
| commit | 3e91b44c93ad2871f89fc2a98c5e4fe6ca5db3d9 (patch) | |
| tree | dd98a4e35f78a20264644df38c8980b5abd2e68c | |
| parent | bbd6e97c836cbeb9606d7b7e5dcf8a1d89525713 (diff) | |
| download | linux-tpmdd-master.tar.gz | |
tpm: st33zp24: Fix missing cleanup on get_burstcount() errorHEADtpmdd-next-7.0-rc1nextmaster
get_burstcount() can return -EBUSY on timeout. When this happens,
st33zp24_send() returns directly without releasing the locality
acquired earlier.
Use goto out_err to ensure proper cleanup when get_burstcount() fails.
Fixes: bf38b8710892 ("tpm/tpm_i2c_stm_st33: Split tpm_i2c_tpm_st33 in 2 layers (core + phy)")
Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
| -rw-r--r-- | drivers/char/tpm/st33zp24/st33zp24.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c index 2ed7815e4899b7..e2b7451ea7ccd3 100644 --- a/drivers/char/tpm/st33zp24/st33zp24.c +++ b/drivers/char/tpm/st33zp24/st33zp24.c @@ -328,8 +328,10 @@ static int st33zp24_send(struct tpm_chip *chip, unsigned char *buf, for (i = 0; i < len - 1;) { burstcnt = get_burstcount(chip); - if (burstcnt < 0) - return burstcnt; + if (burstcnt < 0) { + ret = burstcnt; + goto out_err; + } size = min_t(int, len - i - 1, burstcnt); ret = tpm_dev->ops->send(tpm_dev->phy_id, TPM_DATA_FIFO, buf + i, size); |