Make WordPress Core

Opened 10 days ago

Closed 2 days ago

#64879 closed defect (bug) (fixed)

Admin reskin: Login page still uses legacy hover colors for links

Reported by: wildworks's profile wildworks Owned by: joedolson's profile joedolson
Milestone: 7.0 Priority: normal
Severity: normal Version: trunk
Component: Administration Keywords: admin-reskin has-patch
Focuses: Cc:

Description

The new modern default color should be used for the following links in the login page:

  • Lost your password?
  • ← Go to {site_name}
  • Log in

Attachments (3)

login-page-hovered-link.png (128.6 KB) - added by wildworks 10 days ago.
Link in hover state
fix-admin-screen-links-color.png (37.7 KB) - added by nikunj8866 10 days ago.
Replace login legency hover links
after_hover.png (129.6 KB) - added by noruzzaman 9 days ago.
This patch resolves the hover issues on the login page links.

Download all attachments as: .zip

Change History (17)

@wildworks
10 days ago

Link in hover state

This ticket was mentioned in PR #11284 on WordPress/wordpress-develop by @nikunj8866.


10 days ago
#1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/64879

## Use of AI Tools

@nikunj8866
10 days ago

Replace login legency hover links

#2 @ozgursar
10 days ago

Patch Testing Report

Patch Tested: https://github.com/WordPress/wordpress-develop/pull/11284

Updated my screenshots based on the latest commit on the PR

Environment

  • WordPress: 7.0-beta5-61991-src
  • PHP: 8.2.29
  • Server: nginx/1.29.4
  • Database: mysqli (Server: 8.4.7 / Client: mysqlnd 8.2.29)
  • Browser: Chrome 145.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Five 1.4
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.1
    • WP Button Variations Checker 1.1.0

Steps taken

  1. View the WP login screen
  2. Observe that the links below the input fields are displayed in hard-coded #135e96 text color
  3. Apply the patch
  4. Observe that the links are now displayed with the text color --wp-admin-theme-color and --wp-admin-theme-color-darker-20 when hovered
  5. ✅ Patch is solving the problem

Screenshots/Screencast with results

Before
https://i.imgur.com/AEubpLJ.png

After
https://i.imgur.com/WVNfGtq.png

After (hover state)
https://i.imgur.com/pbuStUL.png

Last edited 10 days ago by ozgursar (previous) (diff)

@huzaifaalmesbah commented on PR #11284:


10 days ago
#3

I noticed that some CSS was removed, including text-decoration: none;. Because of this, the display now looks like this, which doesn’t look good. Also, the hover state and the normal state have the same color, which makes the UI look poor.

https://github.com/user-attachments/assets/b3e83e41-11f8-4810-adb0-fdbbbd2c120d

@wildworks commented on PR #11284:


10 days ago
#4

@nikunj8866 Thanks for working on this.

Please note that only the color needs to be changed here. Any other changes are outside the scope of this ticket.

@nikunj8866 commented on PR #11284:


10 days ago
#5

I've added text-decoration: none; and set the link color to match the default theme color.

#6 @audrasjb
10 days ago

  • Version set to trunk

@shailu25 commented on PR #11284:


10 days ago
#7

The login page link hover color is aligned with the new theme color scheme.✅

BeforeAfter
https://github.com/user-attachments/assets/1ae0881b-b10d-4d06-bb9f-e4ab63439741https://github.com/user-attachments/assets/f4187ed3-9fb2-4e52-b7e8-1b984bcc8a30

@noruzzaman
9 days ago

This patch resolves the hover issues on the login page links.

@wildworks commented on PR #11284:


9 days ago
#8

The default color has changed. This is not the style that was expected.

Before After

| https://github.com/user-attachments/assets/acb9e85e-fd47-4ec6-ace5-1956cd3c3964| https://github.com/user-attachments/assets/4e13198a-bc2c-416b-a6d9-00d9b0b9d137|

#9 @joedolson
5 days ago

  • Owner set to joedolson
  • Status changed from new to accepted

#10 @wildworks
5 days ago

  • Summary changed from Admin resking: Login page still uses legacy hover colors for links to Admin reskin: Login page still uses legacy hover colors for links

#11 @khushi1501
5 days ago

On the login screen, link hover colors still use old styles, which looks inconsistent with the updated admin UI. This is noticeable on links like “Lost your password?” and “← Go to site”.

The patch fixes this and matches the new design.

Before applying the patch:-
https://prnt.sc/3_wCrH9YyArB

After applying the patch:-
https://prnt.sc/hmNomFQxTG3K

#12 @wildworks
5 days ago

I don't think we should do too much with this ticket. We're on the verge of releasing 7.0 RC1. I think we should ship minimal fixes into 7.0. Whether or not we should add an underline can be considered in a follow-up.

This ticket was mentioned in Slack in #core by juanmaguitar. View the logs.


3 days ago

#14 @SergeyBiryukov
2 days ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 62113:

Admin Reskin: Correct hover color for links on the login screen.

Follow-up to [61681].

Reviewed by wildworks, SergeyBiryukov.

Props nikunj8866, wildworks, joedolson, audrasjb, huzaifaalmesbah, shailu25, ozgursar, noruzzaman, khushi1501, SergeyBiryukov.
Fixes #64879.

Note: See TracTickets for help on using tickets.