Make WordPress Core

Opened 4 weeks ago

Closed 4 weeks ago

#64741 closed defect (bug) (fixed)

Change welcome panel background color to light gray

Reported by: marc4's profile Marc4 Owned by: joedolson's profile joedolson
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords: admin-reskin has-patch commit
Focuses: ui Cc:

Description

I suggest matching the welcome panel's border color with the rest of the dashboard widgets to make it more integrated and less jarring.

Here is the PR: https://github.com/WordPress/wordpress-develop/pull/11065

Attachments (1)

header-image-bg.png (98.4 KB) - added by peterwilsoncc 4 weeks ago.

Download all attachments as: .zip

Change History (22)

This ticket was mentioned in PR #11065 on WordPress/wordpress-develop by @Marc4.


4 weeks ago
#1

  • Keywords has-patch added

I suggest matching the welcome panel's border color with the rest of the dashboard widgets.

Ticket: https://core.trac.wordpress.org/ticket/64741

Before: White Background After: Light Gray Background
:--- :---
https://github.com/user-attachments/assets/dceb2af2-2850-4ef1-93be-55e9db558166 https://github.com/user-attachments/assets/a424a3ac-a1da-4564-a88c-5a0d146b4e94

#2 @joedolson
4 weeks ago

  • Keywords admin-reskin added

Thanks, @Marc4! FYI, I added a link to the ticket in your PR so that the automations to connect the two would run.

#3 @joedolson
4 weeks ago

@fabiankaegy What's your thought here? It makes sense to me; the welcome banner has enough to make it stand out already, the border just looks out of place.

#4 @fabiankaegy
4 weeks ago

Thanks for the ping! Yeah this makes sense to me 👍

#5 @joedolson
4 weeks ago

  • Milestone changed from Awaiting Review to 7.0
  • Owner set to joedolson
  • Status changed from new to accepted

#6 @joedolson
4 weeks ago

  • Keywords commit added

#7 @joedolson
4 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 61758:

Admin: Match welcome panel to other dashboard widgets.

Set the Welcome Panel to have the same border color as the other dashboard widgets following the admin reskin.

Props marc4, fabiankaegy, joedolson.
Fixes #64741.

#8 @peterwilsoncc
4 weeks ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

r61758 has caused an issue with the display of welcome banner when displayed on a wide screen, around 1680 pixels or wider.

The black background colour is no longer displayed behind the image so there are grey bars showing instad of the black background.

I've added a before and after in the screen shot above.

Environment

  • WordPress: 7.0-beta2-61758
  • PHP: 8.4.18
  • Server: nginx/1.24.0
  • Database: mysqli (Server: 8.0.44-0ubuntu0.24.04.2 / Client: mysqlnd 8.4.18)
  • Browser: Firefox 148.0
  • OS: macOS
  • Theme: Twenty Twenty-Five 1.4
  • MU Plugins:
    • _qm-mappings.php
  • Plugins:
    • Query Monitor 3.20.2
    • Test Reports 1.2.1

This ticket was mentioned in PR #11105 on WordPress/wordpress-develop by @peterwilsoncc.


4 weeks ago
#9

Trac ticket:

## Use of AI Tools

#10 @ramonopoly
4 weeks ago

has caused an issue with the display of welcome banner when displayed on a wide screen, around 1680 pixels or wider.

Just came to say this. Looks like #151515 matched the svg path fill inside .welcome-panel-header-image

https://github.com/WordPress/wordpress-develop/commit/69aa284de60c7bf6a2613aa516d32537c22c3ac3#diff-cb3a7ed96d1958084e4c9d819cecaf0b6f33e9bec282dce72fa6b116a71ee61dL143

@huzaifaalmesbah commented on PR #11105:


4 weeks ago
#11

1920px without PR:
https://github.com/user-attachments/assets/31cf896e-76f6-4b65-a1e7-0574f68e5759

1920px with PR:
https://github.com/user-attachments/assets/7a8393eb-b932-4750-8ce8-8725741779a0

2560px with PR:
https://github.com/user-attachments/assets/92dd6c22-dcef-4543-8dc0-549acc540aea

This ticket was mentioned in PR #11106 on WordPress/wordpress-develop by @Marc4.


4 weeks ago
#12

If we add background-color: #151515 to welcome-panel-content to fix this: https://github.com/WordPress/wordpress-develop/pull/11105, it might be better to remove the background from welcome-panel and simply modify the border color instead. Does that make sense?

@shailu25 commented on PR #11105:


4 weeks ago
#13

The background color is now displaying correctly on wider screens.

BeforeAfter
https://github.com/user-attachments/assets/301225cf-84d5-467a-932b-c3c99010d7a6https://github.com/user-attachments/assets/6df01ad9-208e-4418-aaa9-a57763981406

@joedolson commented on PR #11106:


4 weeks ago
#14

It leaves a small amount of dark artifacting in the border radius which doesn't match the other dashboard widgets, but I'm unsure that's significant enough to address.

If we added another wrapper for the welcome panel header, we could set a background only on the header panel, which would avoid this.

@joedolson commented on PR #11106:


4 weeks ago
#15

That makes sense to me. It solves the problem we were looking to solve.

@ocean90 commented on PR #11106:


4 weeks ago
#16

During our company contributor day with @karinchristen @krokodok @velthy @derpaschi we fixed two more issues.

https://github.com/WordPress/wordpress-develop/pull/11106/commits/3bad50de53968616d0a36dd25293d1a3d32fc915:
This is a small visual detail, but when the border wraps around the entire element, it appears slightly blurred because .welcome-panel-header-wrap has a dark background.

For this reason, we suggest applying the border only to .welcome-panel-column-container instead. Additionally, add a border-radius of 8px to the bottom-left and bottom-right corners of .welcome-panel-column-container.

After:
https://github.com/user-attachments/assets/45b1f5d3-a291-4788-9f13-49d4c698f1d5

https://github.com/WordPress/wordpress-develop/pull/11106/commits/428f84a6670a80053e7d69be2712ab6646c1e432:
The dismiss icon was missing on smaller screen.

After:
https://github.com/user-attachments/assets/baa5f130-8c5e-4724-94fd-683ac12d126d

@krokodok commented on PR #11106:


4 weeks ago
#17

As @ocean90 said, we worked on this together and it looks better noew.

@karinchristen commented on PR #11106:


4 weeks ago
#18

Works!

@hubeRsen commented on PR #11106:


4 weeks ago
#19

Tested and can confirm that the close icon is shown on mobile and the border is looking better now. 👍🏼

@stefan.velthuys commented on PR #11106:


4 weeks ago
#20

Yep, dismiss icon is visible again and the overall styling of the box looks better and crisper 👍

#21 @joedolson
4 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 61798:

Admin: Reskin - Welcome Panel viewport fixes.

Ensure that the black background covers the entire width of the header on large screens, ensure that the dismiss button appears on small screens.

Props peterwilsoncc, ramonopoly, huzaifaalmesbah, marc4, shailu25, ocean90, krokodok, karinchristen, hubersen, stefanvelthuys, joedolson.
Fixes #64741.

Note: See TracTickets for help on using tickets.