Make WordPress Core

Opened 6 weeks ago

Closed 3 days ago

#64658 closed task (blessed) (fixed)

Update all references to the Verse block to Poetry

Reported by: ellatrix's profile ellatrix Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 7.0 Priority: normal
Severity: normal Version: trunk
Component: Bundled Theme Keywords: has-patch commit dev-reviewed
Focuses: Cc:

Description

The label of the block has changed since https://github.com/WordPress/gutenberg/pull/74121, so we should make sure references to it in themes etc. are updated.

Change History (12)

This ticket was mentioned in PR #10969 on WordPress/wordpress-develop by @jsmansart.


5 weeks ago
#1

  • Keywords has-patch added

I've updated all references in all themes.

I've replace the Verse block name in comments and change wp-block-verse to wp-block-poetry class.

In twentytwentyone there was a need to change the name of a folder, then change the imports and then make a build. I hope I did these well, if not, let me know where I was wrong.

Trac ticket: https://core.trac.wordpress.org/ticket/64658

## Use of AI Tools

None used.

@sabernhardt commented on PR #10969:


5 weeks ago
#2

Undo any changes to the .wp-block-verse class name; the Poetry block still uses that class. The sass folder name should not need to change either.

To avoid confusion, I recommend editing "Verse" to "Poetry (Verse)" in the comments.

Also, please update your fork. It still contains IE styles for Twenty Twenty-One, which were removed in r61628.

#3 @sabernhardt
5 weeks ago

  • Component changed from Editor to Bundled Theme
  • Keywords changes-requested added

@jsmansart commented on PR #10969:


5 weeks ago
#4

Thanks @sabernhardt for your hints.

I have reverted all class names and the sass folder.

I have edited "Verse" to "Poetry (Verse)" in the comments.

And finaly, the fork is up to date.

Let me know if I missed something.

#5 @sabernhardt
5 weeks ago

  • Keywords changes-requested removed

The PR updates 11 lines of CSS comments, and I did not find any similar mentions in the themes when searching "Verse" (capitalized) or "verse " (lowercase followed by a space).

Add props: SirLouen (from GB74121)

#6 @sabernhardt
5 weeks ago

  • Keywords commit added

#7 @sabernhardt
5 weeks ago

When I used npm run build for Twenty Twenty-One, it did not change the .map files. However, I recommend trying it again before committing.

@sabernhardt commented on PR #10969:


4 weeks ago
#8

Could you restore the branch and reopen the pull request? It was not committed.

@jsmansart commented on PR #10969:


4 weeks ago
#9

Sorry for the mess !

#11 @SergeyBiryukov
3 days ago

  • Keywords dev-reviewed added

#12 @SergeyBiryukov
3 days ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 62112:

Bundled Themes: Update all references to the Verse block to Poetry.

Original PR from Gutenberg repository:

Reviewed by wildworks, SergeyBiryukov.

Props jsmansart, ellatrix, wildworks, mukesh27, sabernhardt.
Fixes #64658.

Note: See TracTickets for help on using tickets.