Opened 6 weeks ago
Closed 3 days ago
#64658 closed task (blessed) (fixed)
Update all references to the Verse block to Poetry
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 7.0 | Priority: | normal |
| Severity: | normal | Version: | trunk |
| Component: | Bundled Theme | Keywords: | has-patch commit dev-reviewed |
| Focuses: | Cc: |
Description
The label of the block has changed since https://github.com/WordPress/gutenberg/pull/74121, so we should make sure references to it in themes etc. are updated.
Change History (12)
This ticket was mentioned in PR #10969 on WordPress/wordpress-develop by @jsmansart.
5 weeks ago
#1
- Keywords has-patch added
@sabernhardt commented on PR #10969:
5 weeks ago
#2
Undo any changes to the .wp-block-verse class name; the Poetry block still uses that class. The sass folder name should not need to change either.
To avoid confusion, I recommend editing "Verse" to "Poetry (Verse)" in the comments.
Also, please update your fork. It still contains IE styles for Twenty Twenty-One, which were removed in r61628.
@jsmansart commented on PR #10969:
5 weeks ago
#4
Thanks @sabernhardt for your hints.
I have reverted all class names and the sass folder.
I have edited "Verse" to "Poetry (Verse)" in the comments.
And finaly, the fork is up to date.
Let me know if I missed something.
#5
@
5 weeks ago
- Keywords changes-requested removed
The PR updates 11 lines of CSS comments, and I did not find any similar mentions in the themes when searching "Verse" (capitalized) or "verse " (lowercase followed by a space).
Add props: SirLouen (from GB74121)
#7
@
5 weeks ago
When I used npm run build for Twenty Twenty-One, it did not change the .map files. However, I recommend trying it again before committing.
@sabernhardt commented on PR #10969:
4 weeks ago
#8
Could you restore the branch and reopen the pull request? It was not committed.
@jsmansart commented on PR #10969:
4 weeks ago
#9
Sorry for the mess !
#10
@
9 days ago
I think https://github.com/WordPress/wordpress-develop/pull/10969 is ready to land.
I've updated all references in all themes.
I've replace the
Verseblock name in comments and changewp-block-versetowp-block-poetryclass.In
twentytwentyonethere was a need to change the name of a folder, then change the imports and then make a build. I hope I did these well, if not, let me know where I was wrong.Trac ticket: https://core.trac.wordpress.org/ticket/64658
## Use of AI Tools
None used.