wp_die() status code Themes component updates (parent ticket: #64009)

[callumbw95]

If you have come here directly, please refer back to the parent ticket here: #64009

This ticket is regarding the wp_die() function calls within the Media component and will cover the following locations. Please note links were correct at the time of testing and writing this up, but line numbers may have changed slightly:

Filepath	Line Number	Context	Status Code	New Code	Code Meaning
src/wp-admin/themes.php	​86	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/themes.php	​106	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/theme-editor.php	​18	User Permissions: does not have access	500	403	Forbidden
src/wp-admin/theme-editor.php	​73	Missing: theme	500	404	Not Found
src/wp-admin/theme-install.php	​16	User Permissions: does not have access	500	403	Forbidden

There are however the following function calls I have not touched as I felt they were already valid with their current status code:

Filepath	Line Number	Status Code
src/wp-admin/includes/theme-install.php	​261	500
src/wp-admin/themes.php	​13	403
src/wp-admin/themes.php	​26	403
src/wp-admin/themes.php	​41	403
src/wp-admin/themes.php	​51	500
src/wp-admin/themes.php	​61	403
src/wp-admin/themes.php	​69	403
src/wp-content/themes/twentyfifteen/inc/back-compat.php	​53	500
src/wp-content/themes/twentyfifteen/inc/back-compat.php	​74	500
src/wp-content/themes/twentyfourteen/inc/back-compat.php	​53	500
src/wp-content/themes/twentyfourteen/inc/back-compat.php	​74	500
src/wp-content/themes/twentynineteen/inc/back-compat.php	​57	500
src/wp-content/themes/twentynineteen/inc/back-compat.php	​80	500
src/wp-content/themes/twentyseventeen/inc/back-compat.php	​57	500
src/wp-content/themes/twentyseventeen/inc/back-compat.php	​80	500
src/wp-content/themes/twentysixteen/inc/back-compat.php	​59	500
src/wp-content/themes/twentysixteen/inc/back-compat.php	​82	500
src/wp-content/themes/twentythirteen/inc/back-compat.php	​53	500
src/wp-content/themes/twentythirteen/inc/back-compat.php	​74	500
src/wp-content/themes/twentytwentyone/inc/back-compat.php	​58	500
src/wp-content/themes/twentytwentyone/inc/back-compat.php	​83	500
src/wp-includes/theme.php	​765	500

Please have a look through the suggested changes documented here, and any/all feedback is appreciated. 😃

…s related to the Themes component

Trac ticket: #64057

@CallumBW95 looks good. The failed checks appear to be related to a GitHub outage on macOS builds.

​https://www.githubstatus.com/

@mindctrl Ah ok, is there anyway I can rerun the tests as it looks like there are no issues with MacOS runners now?

@CallumBW95 AFAIK the only way, without extra permissions to this repo, is to push another commit.