Opened 7 months ago
Last modified 2 weeks ago
#63372 accepted defect (bug)
Tags page UI inconsistencies when adding or deleting tags
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 7.0 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Administration | Keywords: | has-patch has-test-info changes-requested |
| Focuses: | ui, accessibility, javascript, css | Cc: |
Description
There are several UI issues on the Tags page in the WordPress admin when adding or deleting tags:
1. "No tags found." message not shown after last tag is deleted:
When all tags are removed using the JavaScript interface, the message "No tags found." does not appear until the page is manually refreshed. Also, the .tablenav sections (top and bottom) are not removed immediately and remain visible until refresh.
2. Bulk action and item count does not reappear when a new tag is added via JS:
If there are no tags and a new tag is added using the input form (handled via JavaScript), the .tablenav sections remain hidden and do not reappear unless the page is refreshed.
3. Pagination count not updated:
When tags are added or deleted via JavaScript and the tag list is paginated, the pagination count is not updated accordingly. This leads to inconsistencies between the actual number of tags and what's shown in the pagination controls.
These issues appear to stem from the fact that while tag creation and deletion are handled client-side via JavaScript, updates to .tablenav visibility and pagination count are handled by PHP and only rendered on full page reload.
Steps to reproduce
- Go to Posts > Tags.
- Delete all tags using the delete links in the table (handled via JS).
- Notice that the "No tags found." message does not appear.
.tablenavsections remain visible.
- Refresh and Add a new tag using the "Add New Tag" form.
- The new tag appears in the list via JavaScript.
- However, the
.tablenavsections remain hidden and do not reappear.
- Add or delete tags while viewing a paginated list.
- The pagination count does not reflect the updated number of tags.
Environment
- WordPress: 6.9-alpha-60093-src
- PHP: 8.2.28
- Server: nginx/1.27.5
- Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
- Browser: Chrome 135.0.0.0
- OS: macOS
- Theme: Twenty Twenty-Five 1.2
- MU Plugins: None activated
- Plugins: Test Reports 1.2.0
Screencast
https://rioudcpuyg.ufs.sh/f/PL8E4NiPUWyOaBpE7dHJcb5UXrLqDIo97jZKdMWg8iplmysR
Change History (18)
This ticket was mentioned in PR #8761 on WordPress/wordpress-develop by @sainathpoojary.
7 months ago
#1
- Keywords has-patch added
#2
@
7 months ago
- Keywords changes-requested has-testing-info added
Combined Reproduction and Patch Test Report
Description
❌ This report can't validate that the indicated patch works completely as expected.
Patch tested: https://github.com/WordPress/wordpress-develop/pull/8761.diff
Environment
- WordPress: 6.9-alpha-60093-src
- PHP: 8.2.28
- Server: nginx/1.27.5
- Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
- Browser: Chrome 135.0.0.0
- OS: Windows 10/11
- Theme: Twenty Twenty-One 2.5
- MU Plugins: None activated
- Plugins:
- Test Reports 1.2.0
Reproduction Steps
- Screen Options ⇒ Fixed to Number of items per page (10) for pagination
- Create some tags
- Remove all tags
- 🐞 First bug reproduced (no "No tags found", message)
- Start adding tags
- 🐞 Second bug reproduced (
tablenavappears) - 🐞 Third bug reproduced The number of items don't update
- 🐞 Extra potential bug: When reaching the fixed number of items per page (10 in my case), pagination doesn't appear when we have more than 10 items, until we refresh.
Expected results
- When all tags are removed, "No tags found" should appear
- The
tablenavshould appear as soon as there are new tags to be able to deal with them - The number of items should update every new tag we create
- Reaching the Number of items per page, should add a pagination control.
Actual Results with Patch
- ✅ "No tags found" appears correctly when all tags removed
- ❌
tablenavstill doesn't appear after adding new tags - ❌ Number of items don't appear
- ❌ With a refresh number of items appear, but they don't update with each new tag
- ❌ When reaching the "Number of items per page", the pagination control still doesn't appear without refresh.
Additional Notes
Added a screencast to showcase the problems that still exist
Supplemental Artifacts
Screencast: https://f003.backblazeb2.com/file/wordpress-videos/wp-videos/2025/05/63372.mp4
#5
@
5 months ago
- Keywords changes-requested removed
Thanks for the detailed test report @SirLouen! I’ve since updated the PR to address all reported issues, and it’s now ready for review.
#7
@
5 months ago
Reproduction Report
Description
This report validates whether the issue can be reproduced.
Environment
- WordPress: 6.9-alpha-60093-src
- PHP: 8.2.28
- Server: nginx/1.27.5
- Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
- Browser: Chrome 137.0.0.0
- OS: macOS
- Theme: Twenty Twenty 2.9
- MU Plugins: None activated
- Plugins:
- Test Reports 1.2.0
Actual Results
- ✅ Error condition occurs (reproduced).
Supplemental Artifacts
https://ifnmp28oya.ufs.sh/f/0nfskUTEKfUZUOlu5SNmYySW2Gs6Vh5nKvcp49ITxeMZNwbA
#8
@
5 months ago
Test Report
Description
This report validates whether the indicated patch works as expected.
Patch tested: https://github.com/WordPress/wordpress-develop/pull/8761.diff
Environment
- WordPress: 6.9-alpha-60093-src
- PHP: 8.2.28
- Server: nginx/1.27.5
- Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
- Browser: Chrome 137.0.0.0
- OS: macOS
- Theme: Twenty Twenty-One 2.5
- MU Plugins: None activated
- Plugins:
- Test Reports 1.2.0
Actual Results
- ✅ "No tags found" appears correctly when all tags removed
- ✅ tablenav appears after adding new tags
- ✅ Number of items appear
- ✅ The number of items update with each operation
- ❌ When reaching the limit "Number of items per page", the pagination control still doesn't appear without refresh.
Additional Notes
- In general, when adding/deleting tags, the pagination doesn't update accordingly. eg. if viewing a fixed number of tags & deleting all of them, the next set of tags don't appear until full page refresh
Supplemental Artifacts
Screencast: https://files.catbox.moe/40dqpy.mov
#9
@
5 months ago
- Keywords changes-requested added; needs-testing removed
@sainathpoojary it seems here have been spotted still some troubles with the patch
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
5 months ago
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
3 months ago
#13
@
3 months ago
- Milestone changed from Awaiting Review to 6.9
Since this has a pretty well-progressed patch, I'm going to milestone this for 6.9; it seems within reach to get finished soon.
Regarding the missing point - while that would be nice to have, I'd also say it's somewhat of an edge case. It would only occur if somebody adds more terms via AJAX than their current pagination limits, and the actions of adding tags in bulk are fairly separate from the actions of exploring your tags.
It would be good to get it fixed, but this would still be a significant improvement without that, so it shouldn't necessarily block it from moving forward.
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
7 weeks ago
This ticket was mentioned in Slack in #accessibility by a.k._azad. View the logs.
5 weeks ago
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
4 weeks ago
@joedolson commented on PR #8761:
3 weeks ago
#17
I made some refinements to this, but I'm in doubt whether it will be ready in time for 6.9. One issue was that the previous force push had overwritten some previous accessibility improvements; you'll want to be a bit more careful when merging prior changes in.
This PR fixes:
.tablenavsections when no tags are present..tablenavsections when a new tag is added via JS if none previously existed.Trac ticket: #63372