Changeset 62047

Timestamp:

03/18/2026 09:02:09 PM (9 days ago)

Author:

SergeyBiryukov

Message:

Query: Check that taxonomy query var is a string in WP_Query::parse_tax_query().

This prevents a fatal error from urldecode() in wp_basename() if an array is passed instead.

Follow-up to [15732], [15824], [15825], [15923], [16155], [50565], [60927].

Props patricedefago, alexodiy, SergeyBiryukov.
Fixes #64870.

Location:

trunk

Files:

• src/wp-includes/class-wp-query.php (modified) (1 diff)
• tests/phpunit/tests/query/parseQuery.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-query.php

@@ -1190 +1190 @@
                 );
 
-                if ( ! empty( $t->rewrite['hierarchical'] ) ) {
+                if ( is_string( $query_vars[ $t->query_var ] ) && ! empty( $t->rewrite['hierarchical'] ) ) {
                     $query_vars[ $t->query_var ] = wp_basename( $query_vars[ $t->query_var ] );
                 }

trunk/tests/phpunit/tests/query/parseQuery.php

@@ -234 +234 @@
         $this->assertEmpty( $q->query_vars['attachment_id'] );
     }
+
+    /**
+     * Tests that a fatal error is not thrown when a hierarchical taxonomy query var
+     * passed to wp_basename() in ::parse_tax_query() is an array instead of a string.
+     *
+     * The message that we should not see:
+     * `TypeError: urldecode(): Argument #1 ($string) must be of type string, array given`.
+     *
+     * @ticket 64870
+     */
+    public function test_parse_query_hierarchical_taxonomy_query_var_array() {
+        register_taxonomy(
+            'wptests_tax',
+            'post',
+            array(
+                'query_var' => 'wptests_tax',
+                'rewrite'   => array( 'hierarchical' => true ),
+                'public'    => true,
+            )
+        );
+
+        $q = new WP_Query(
+            array(
+                'wptests_tax' => array( 'term-a', 'term-b' ),
+            )
+        );
+
+        unregister_taxonomy( 'wptests_tax' );
+
+        $this->assertIsArray( $q->posts );
+    }
 }