Changeset 61920

Timestamp:

03/11/2026 12:17:01 AM (2 weeks ago)

Author:

peterwilsoncc

Message:

Grouped backports for the 6.5 branch.

• Interactivity API: Skip binding event handler attributes. The corresponding data-wp-on-- attribute should be used instead.
• Customize: Introduce a fix for themes that pass a stringable object through the template_include filter despite it being documented as only accepting a string.

Location:

branches/6.5

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-block-patterns-registry.php (modified) (1 diff)
• src/wp-includes/interactivity-api/class-wp-interactivity-api.php (modified) (1 diff)
• src/wp-includes/template-loader.php (modified) (1 diff)

branches/6.5/src/wp-includes/class-wp-block-patterns-registry.php

@@ -200 +200 @@
         }
 
-        $pattern_path = realpath( $patterns[ $pattern_name ]['filePath'] ?? '' );
+        $file_path    = $patterns[ $pattern_name ]['filePath'] ?? '';
+        $is_stringy   = is_string( $file_path ) || ( is_object( $file_path ) && method_exists( $file_path, '__toString' ) );
+        $pattern_path = $is_stringy ? realpath( (string) $file_path ) : null;
         if (
             ! isset( $patterns[ $pattern_name ]['content'] ) &&

branches/6.5/src/wp-includes/interactivity-api/class-wp-interactivity-api.php

@@ -673 +673 @@
                 }
 
+                // Skip if the bound attribute is an event handler.
+                if ( str_starts_with( $bound_attribute, 'on' ) ) {
+                    _doing_it_wrong(
+                        __METHOD__,
+                        sprintf(
+                            /* translators: %s: The directive, e.g. data-wp-on--click. */
+                            __( 'Binding event handler attributes is not supported. Please use "%s" instead.' ),
+                            esc_attr( 'data-wp-on--' . substr( $bound_attribute, 2 ) )
+                        ),
+                        '6.8.5'
+                    );
+                    continue;
+                }
+
                 $attribute_value = $p->get_attribute( $attribute_name );
                 $result          = $this->evaluate( $attribute_value, end( $namespace_stack ), end( $context_stack ) );

branches/6.5/src/wp-includes/template-loader.php

@@ -102 +102 @@
      * @param string $template The path of the template to include.
      */
-    $template = apply_filters( 'template_include', $template );
-    $template = is_string( $template ) ? realpath( $template ) : null;
+    $template   = apply_filters( 'template_include', $template );
+    $is_stringy = is_string( $template ) || ( is_object( $template ) && method_exists( $template, '__toString' ) );
+    $template   = $is_stringy ? realpath( (string) $template ) : null;
     if (
         is_string( $template ) &&