Changeset 61435

Timestamp:

01/05/2026 05:56:34 AM (3 months ago)

Author:

westonruter

Message:

Code Modernization: HTTP: Use null coalescing operator instead of isset() ternaries.

Developed as a subset of ​https://github.com/WordPress/wordpress-develop/pull/10654
Initially developed in ​https://github.com/WordPress/wordpress-develop/pull/4886

Follow-up to [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403].

Props costdev, westonruter.
See #58874, #63430.

Location:

trunk/src/wp-includes

Files:

• class-wp-http-cookie.php (modified) (2 diffs)
• class-wp-http-ixr-client.php (modified) (1 diff)
• class-wp-http.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-http-cookie.php

@@ -115 +115 @@
             $this->domain = $parsed_url['host'];
         }
-        $this->path = isset( $parsed_url['path'] ) ? $parsed_url['path'] : '/';
+        $this->path = $parsed_url['path'] ?? '/';
         if ( ! str_ends_with( $this->path, '/' ) ) {
             $this->path = dirname( $this->path ) . '/';
@@ -191 +191 @@
         // Get details on the URL we're thinking about sending to.
         $url         = parse_url( $url );
-        $url['port'] = isset( $url['port'] ) ? $url['port'] : ( 'https' === $url['scheme'] ? 443 : 80 );
-        $url['path'] = isset( $url['path'] ) ? $url['path'] : '/';
+        $url['port'] = $url['port'] ?? ( 'https' === $url['scheme'] ? 443 : 80 );
+        $url['path'] = $url['path'] ?? '/';
 
         // Values to use for comparison against the URL.
-        $path   = isset( $this->path ) ? $this->path : '/';
-        $port   = isset( $this->port ) ? $this->port : null;
+        $path   = $this->path ?? '/';
+        $port   = $this->port ?? null;
         $domain = isset( $this->domain ) ? strtolower( $this->domain ) : strtolower( $url['host'] );
         if ( false === stripos( $domain, '.' ) ) {

trunk/src/wp-includes/class-wp-http-ixr-client.php

@@ -26 +26 @@
             $this->scheme = $bits['scheme'];
             $this->server = $bits['host'];
-            $this->port   = isset( $bits['port'] ) ? $bits['port'] : $port;
+            $this->port   = $bits['port'] ?? $port;
             $this->path   = ! empty( $bits['path'] ) ? $bits['path'] : '/';
 

trunk/src/wp-includes/class-wp-http.php

@@ -693 +693 @@
         return array(
             'headers' => $response[0],
-            'body'    => isset( $response[1] ) ? $response[1] : '',
+            'body'    => $response[1] ?? '',
         );
     }