Changeset 61432 for trunk/src/wp-admin/includes/widgets.php

Timestamp:

01/05/2026 05:32:00 AM (3 months ago)

Author:

westonruter

Message:

Code Modernization: Widgets: Use null coalescing operator instead of isset() ternaries.

Developed as a subset of ​https://github.com/WordPress/wordpress-develop/pull/10654
Initially developed in ​https://github.com/WordPress/wordpress-develop/pull/4886

Follow-up to [61431], [61430], [61429], [61424], [61404], [61403].

Props costdev, westonruter.
See #58874, #63430.

File:

• trunk/src/wp-admin/includes/widgets.php (modified) (2 diffs)

trunk/src/wp-admin/includes/widgets.php

@@ -138 +138 @@
 
     $widget_id = $params[0]['widget_id'];
-    $id        = isset( $params[0]['_temp_id'] ) ? $params[0]['_temp_id'] : $widget_id;
+    $id        = $params[0]['_temp_id'] ?? $widget_id;
     $hidden    = isset( $params[0]['_hide'] ) ? ' style="display:none;"' : '';
 
@@ -192 +192 @@
 
     $widget_id  = $sidebar_args['widget_id'];
-    $sidebar_id = isset( $sidebar_args['id'] ) ? $sidebar_args['id'] : false;
+    $sidebar_id = $sidebar_args['id'] ?? false;
     $key        = $sidebar_id ? array_search( $widget_id, $sidebars_widgets[ $sidebar_id ], true ) : '-1'; // Position of widget in sidebar.
-    $control    = isset( $wp_registered_widget_controls[ $widget_id ] ) ? $wp_registered_widget_controls[ $widget_id ] : array();
+    $control    = $wp_registered_widget_controls[ $widget_id ] ?? array();
     $widget     = $wp_registered_widgets[ $widget_id ];
 
     $id_format     = $widget['id'];
-    $widget_number = isset( $control['params'][0]['number'] ) ? $control['params'][0]['number'] : '';
-    $id_base       = isset( $control['id_base'] ) ? $control['id_base'] : $widget_id;
-    $width         = isset( $control['width'] ) ? $control['width'] : '';
-    $height        = isset( $control['height'] ) ? $control['height'] : '';
-    $multi_number  = isset( $sidebar_args['_multi_num'] ) ? $sidebar_args['_multi_num'] : '';
-    $add_new       = isset( $sidebar_args['_add'] ) ? $sidebar_args['_add'] : '';
-
-    $before_form           = isset( $sidebar_args['before_form'] ) ? $sidebar_args['before_form'] : '<form method="post">';
-    $after_form            = isset( $sidebar_args['after_form'] ) ? $sidebar_args['after_form'] : '</form>';
-    $before_widget_content = isset( $sidebar_args['before_widget_content'] ) ? $sidebar_args['before_widget_content'] : '<div class="widget-content">';
-    $after_widget_content  = isset( $sidebar_args['after_widget_content'] ) ? $sidebar_args['after_widget_content'] : '</div>';
+    $widget_number = $control['params'][0]['number'] ?? '';
+    $id_base       = $control['id_base'] ?? $widget_id;
+    $width         = $control['width'] ?? '';
+    $height        = $control['height'] ?? '';
+    $multi_number  = $sidebar_args['_multi_num'] ?? '';
+    $add_new       = $sidebar_args['_add'] ?? '';
+
+    $before_form           = $sidebar_args['before_form'] ?? '<form method="post">';
+    $after_form            = $sidebar_args['after_form'] ?? '</form>';
+    $before_widget_content = $sidebar_args['before_widget_content'] ?? '<div class="widget-content">';
+    $after_widget_content  = $sidebar_args['after_widget_content'] ?? '</div>';
 
     $query_arg = array( 'editwidget' => $widget['id'] );