Changeset 61416 for trunk/src/wp-includes/script-loader.php

Timestamp:

12/29/2025 06:59:20 PM (3 months ago)

Author:

westonruter

Message:

Script Loader: Warn when a registered style has invalid path data and allow inlining empty stylesheets.

When a stylesheet is registered with a path that does not exist or which is not readable, then a _doing_it_wrong() is now issued. Previously, paths that did not exist were silently skipped; paths for empty styles were also needlessly skipped, since wp_filesize() also returns 0 for the failure case.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10653

Follow-up to [50836].

Props westonruter, jonsurrell, soyebsalar01.
See #52620.
Fixes #64447.

File:

• trunk/src/wp-includes/script-loader.php (modified) (2 diffs)

trunk/src/wp-includes/script-loader.php

@@ -3011 +3011 @@
         if ( $path && $src ) {
             $size = wp_filesize( $path );
-            if ( ! $size ) {
+            if ( 0 === $size && ! file_exists( $path ) ) {
+                _doing_it_wrong(
+                    __FUNCTION__,
+                    sprintf(
+                        /* translators: 1: 'path', 2: filesystem path, 3: style handle */
+                        __( 'Unable to read the "%1$s" key with value "%2$s" for stylesheet "%3$s".' ),
+                        'path',
+                        esc_html( $path ),
+                        esc_html( $handle )
+                    ),
+                    '7.0.0'
+                );
                 continue;
             }
@@ -3049 +3060 @@
 
             // Get the styles if we don't already have them.
+            if ( ! is_readable( $style['path'] ) ) {
+                _doing_it_wrong(
+                    __FUNCTION__,
+                    sprintf(
+                        /* translators: 1: 'path', 2: filesystem path, 3: style handle */
+                        __( 'Unable to read the "%1$s" key with value "%2$s" for stylesheet "%3$s".' ),
+                        'path',
+                        esc_html( $style['path'] ),
+                        esc_html( $style['handle'] )
+                    ),
+                    '7.0.0'
+                );
+                continue;
+            }
             $style['css'] = file_get_contents( $style['path'] );