Changeset 60992

Timestamp:

10/20/2025 09:00:45 PM (5 weeks ago)

Author:

spacedmonkey

Message:

Users: Avoid fetching all user meta keys in is_user_member_of_blog()

In [33771], is_user_member_of_blog() was optimised to improve the performance of get_blogs_of_user().
That change used $meta_key = to fetch all user meta, which can cause unnecessary data loading and makes it difficult to use the get_{$meta_type}_metadata filter. When all meta keys are retrieved, it’s not possible to tell which specific meta value is being requested for short-circuiting or custom handling.

This commit updates the logic to request only the meta key related to the blog’s capability check, reducing overhead and improving compatibility with metadata filters.

Props rinatkhaziev, spacedmonkey.
Fixes #63989.

File:

• trunk/src/wp-includes/user.php (modified) (1 diff)

trunk/src/wp-includes/user.php

@@ -1197 +1197 @@
     }
 
-    $keys = get_user_meta( $user_id );
-    if ( empty( $keys ) ) {
-        return false;
-    }
-
-    // No underscore before capabilities in $base_capabilities_key.
-    $base_capabilities_key = $wpdb->base_prefix . 'capabilities';
-    $site_capabilities_key = $wpdb->base_prefix . $blog_id . '_capabilities';
-
-    if ( isset( $keys[ $base_capabilities_key ] ) && 1 === $blog_id ) {
-        return true;
-    }
-
-    if ( isset( $keys[ $site_capabilities_key ] ) ) {
-        return true;
-    }
-
-    return false;
+
+    if ( 1 === $blog_id ) {
+        $capabilities_key = $wpdb->base_prefix . 'capabilities';
+    } else {
+        $capabilities_key = $wpdb->base_prefix . $blog_id . '_capabilities';
+    }
+    $has_cap = get_user_meta( $user_id, $capabilities_key, true );
+
+    return is_array( $has_cap );
 }