Changeset 60697 for trunk/src/wp-includes/class-wp-comment-query.php

Timestamp:

08/31/2025 09:41:54 PM (7 months ago)

Author:

spacedmonkey

Message:

Caching API: Use consistent cache keys for query groups.

Query-based caches are now improved by reusing cache keys. Previously, cache keys for query caches were generated using the last_changed value as part of the key. This meant that whenever last_changed was updated, all the previously cached values for the group became unreachable.

The new approach allows WordPress to replace previously cached results that are known to be stale. The previous approach relied on the object cache backend evicting stale keys which is done at various levels of efficiency.

To address this, the following new helper functions have been introduced:

• wp_cache_get_salted
• wp_cache_set_salted
• wp_cache_get_multiple_salted
• wp_cache_set_multiple_salted

These functions provide a consistent way to get/set query caches. Instead of using the last_changed value as part of the cache key, it is now stored inside the cache value as a "salt". This allows cache keys to be reused, with values updated in place rather than relying on eviction of outdated entries.

Props spacedmonkey, peterwilsoncc, flixos90, sanchothefat, tillkruess, rmccue, mukesh27, adamsilverstein, owi, nickchomey.

File:

• trunk/src/wp-includes/class-wp-comment-query.php (modified) (4 diffs)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -452 +452 @@
         $last_changed = wp_cache_get_last_changed( 'comment' );
 
-        $cache_key   = "get_comments:$key:$last_changed";
-        $cache_value = wp_cache_get( $cache_key, 'comment-queries' );
+        $cache_key   = "get_comments:$key";
+        $cache_value = wp_cache_get_salted( $cache_key, 'comment-queries', $last_changed );
         if ( false === $cache_value ) {
             $comment_ids = $this->get_comment_ids();
@@ -464 +464 @@
                 'found_comments' => $this->found_comments,
             );
-            wp_cache_add( $cache_key, $cache_value, 'comment-queries' );
+            wp_cache_set_salted( $cache_key, $cache_value, 'comment-queries', $last_changed );
         } else {
             $comment_ids          = $cache_value['comment_ids'];
@@ -1045 +1045 @@
                 $cache_keys = array();
                 foreach ( $_parent_ids as $parent_id ) {
-                    $cache_keys[ $parent_id ] = "get_comment_child_ids:$parent_id:$key:$last_changed";
-                }
-                $cache_data = wp_cache_get_multiple( array_values( $cache_keys ), 'comment-queries' );
+                    $cache_keys[ $parent_id ] = "get_comment_child_ids:$parent_id:$key";
+                }
+                $cache_data = wp_cache_get_multiple_salted( array_values( $cache_keys ), 'comment-queries', $last_changed );
                 foreach ( $_parent_ids as $parent_id ) {
                     $parent_child_ids = $cache_data[ $cache_keys[ $parent_id ] ];
@@ -1081 +1081 @@
                 $data = array();
                 foreach ( $parent_map as $parent_id => $children ) {
-                    $cache_key          = "get_comment_child_ids:$parent_id:$key:$last_changed";
+                    $cache_key          = "get_comment_child_ids:$parent_id:$key";
                     $data[ $cache_key ] = $children;
                 }
-                wp_cache_set_multiple( $data, 'comment-queries' );
+                wp_cache_set_multiple_salted( $data, 'comment-queries', $last_changed );
             }