Changeset 54348 for trunk/src/wp-includes/class-wp-styles.php

Timestamp:

09/28/2022 02:57:55 PM (3 years ago)

Author:

audrasjb

Message:

Script Loader: Prevent double space between attributes in WP_Styles class.

This changeset prevents <link /> elements to display a double space between attributes when no title attribute is provided.

Props elten, audrasjb, whaze, SergeyBiryukov.
Fixes #56675.

File:

• trunk/src/wp-includes/class-wp-styles.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-styles.php

@@ -225 +225 @@
 
         $rel   = isset( $obj->extra['alt'] ) && $obj->extra['alt'] ? 'alternate stylesheet' : 'stylesheet';
-        $title = isset( $obj->extra['title'] ) ? sprintf( "title='%s'", esc_attr( $obj->extra['title'] ) ) : '';
+        $title = isset( $obj->extra['title'] ) ? sprintf( " title='%s'", esc_attr( $obj->extra['title'] ) ) : '';
 
         $tag = sprintf(
-            "<link rel='%s' id='%s-css' %s href='%s'%s media='%s' />\n",
+            "<link rel='%s' id='%s-css'%s href='%s'%s media='%s' />\n",
             $rel,
             $handle,
@@ -260 +260 @@
 
             $rtl_tag = sprintf(
-                "<link rel='%s' id='%s-rtl-css' %s href='%s'%s media='%s' />\n",
+                "<link rel='%s' id='%s-rtl-css'%s href='%s'%s media='%s' />\n",
                 $rel,
                 $handle,