Make WordPress Core


Ignore:
Timestamp:
05/23/2018 10:04:22 AM (8 years ago)
Author:
pento
Message:

Once upon a midnight dreary, while I coded, weak and weary,
In many a strange and curious file of forgotten lore—
While I pondered, blaming Nacin, my notifications suddenly awakened,
As of someone quietly DMing;—DMing me, I can’t ignore.
“’Tis some contributor,” I muttered, “DMing me an idea or four—

Only this and nothing more.”

Ah, distinctly I remember, at WordCamp US, last December;
A mad proposal nearly laid me—down out cold—upon the floor.
Curious, I listened closely;—to a plan I agreed with, mostly—
A way to make our JavaScript—JavaScript which was a chore—
Maintainable, extendable, for the future, is what I saw.

Guten-ready for evermore.

Open here I switch to Slack, when, with many a patch and hack,
In there stepped Omar, a JavaScript developer hardcore;
Pronouncing all the changes fit; ready now to be commit;
“There’s nothing else for us to do,” DMing me, “It’s done!” he swore—
“No longer random guessing at which file need next be explored—

Let’s move on, we’re all aboard.”

Moved all together, grouped and managed, in folders all is packaged,
The code had all been cleaned and tidied, important parts moved to the fore,
“Though this change be useful here,” I said, “it is too large, I fear,
We couldn’t manage such a patch, we’ve done nothing like this before—
Tell me where doth go this change, change to make our codebase soar!”

Quoth Omar, “In WordPress Core.”

Props omarreis for shepherding this significant change.
Props adamsilverstein, aduth, atimmer, dingo_bastard, frank-klein, gziolo, herregroen, jaswrks, jeremyfelt, jipmoors, jorbin, netweb, ocean90, pento, tjnowell, and youknowriad for testing, feedback, discussion, encouragement, commiserations, etc.
I make no apologies for this commit message.
Fixes #43055.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/css/forms.css

    r43282 r43309  
    835835    bottom: 9px;
    836836    background: transparent;
    837     -webkit-transform: skew(20deg) rotate(6deg);
    838837    transform: skew(20deg) rotate(6deg);
    839838    box-shadow: 0 10px 8px rgba(0, 0, 0, 0.6);
     
    841840
    842841.pressthis-bookmarklet:hover:after {
    843     -webkit-transform: skew(20deg) rotate(9deg);
    844842    transform: skew(20deg) rotate(9deg);
    845843    box-shadow: 0 10px 8px rgba(0, 0, 0, 0.7);
     
    12051203    color: #f56e28;
    12061204    content: "\f463";
    1207     -webkit-animation: rotation 2s infinite linear;
    12081205    animation: rotation 2s infinite linear;
    12091206}
     
    15701567}
    15711568
    1572 @-webkit-keyframes rotation {
    1573     0% {
    1574         -webkit-transform: rotate(0deg);
    1575         transform: rotate(0deg);
    1576     }
    1577     100% {
    1578         -webkit-transform: rotate(359deg);
    1579         transform: rotate(359deg);
    1580     }
    1581 }
    1582 
    15831569@keyframes rotation {
    15841570    0% {
    1585         -webkit-transform: rotate(0deg);
    15861571        transform: rotate(0deg);
    15871572    }
    15881573    100% {
    1589         -webkit-transform: rotate(359deg);
    15901574        transform: rotate(359deg);
    15911575    }
Note: See TracChangeset for help on using the changeset viewer.