WordPress.org
Get WordPress

Make WordPress Core


Ignore:
Timestamp:
05/23/2018 10:04:22 AM (8 years ago)
Author:
pento
Message:

Once upon a midnight dreary, while I coded, weak and weary,
In many a strange and curious file of forgotten lore—
While I pondered, blaming Nacin, my notifications suddenly awakened,
As of someone quietly DMing;—DMing me, I can’t ignore.
“’Tis some contributor,” I muttered, “DMing me an idea or four—

Only this and nothing more.”

Ah, distinctly I remember, at WordCamp US, last December;
A mad proposal nearly laid me—down out cold—upon the floor.
Curious, I listened closely;—to a plan I agreed with, mostly—
A way to make our JavaScript—JavaScript which was a chore—
Maintainable, extendable, for the future, is what I saw.

Guten-ready for evermore.

Open here I switch to Slack, when, with many a patch and hack,
In there stepped Omar, a JavaScript developer hardcore;
Pronouncing all the changes fit; ready now to be commit;
“There’s nothing else for us to do,” DMing me, “It’s done!” he swore—
“No longer random guessing at which file need next be explored—

Let’s move on, we’re all aboard.”

Moved all together, grouped and managed, in folders all is packaged,
The code had all been cleaned and tidied, important parts moved to the fore,
“Though this change be useful here,” I said, “it is too large, I fear,
We couldn’t manage such a patch, we’ve done nothing like this before—
Tell me where doth go this change, change to make our codebase soar!”

Quoth Omar, “In WordPress Core.”

Props omarreis for shepherding this significant change.
Props adamsilverstein, aduth, atimmer, dingo_bastard, frank-klein, gziolo, herregroen, jaswrks, jeremyfelt, jipmoors, jorbin, netweb, ocean90, pento, tjnowell, and youknowriad for testing, feedback, discussion, encouragement, commiserations, etc.
I make no apologies for this commit message.
Fixes #43055.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/wp-admin/css/customize-controls.css

    r42641 r43309  
    158158    width: 30px;
    159159    float: left;
    160     -webkit-transform: none;
    161160    transform: none;
    162161    margin-top: 0;
    … …  
    635634    padding: 0;
    636635    box-sizing: border-box;
    637     transition: 0.18s -webkit-transform cubic-bezier(0.645, 0.045, 0.355, 1);
    638     transition: 0.18s transform cubic-bezier(0.645, 0.045, 0.355, 1);
    639     transition: 0.18s transform cubic-bezier(0.645, 0.045, 0.355, 1), 0.18s -webkit-transform cubic-bezier(0.645, 0.045, 0.355, 1); /* easeInOutCubic */
     636    transition: 0.18s transform cubic-bezier(0.645, 0.045, 0.355, 1); /* easeInOutCubic */
    640637}
    641638
    … …  
    651648    max-height: none;
    652649    overflow: auto;
    653     -webkit-transform: none;
    654650    transform: none;
    655651}
    … …  
    663659    max-height: none;
    664660    overflow: hidden;
    665     -webkit-transform: translateX(100%);
    666661    transform: translateX(100%);
    667662}
    … …  
    669664#customize-theme-controls .customize-pane-child.open,
    670665#customize-theme-controls .customize-pane-child.current-panel {
    671     -webkit-transform: none;
    672666    transform: none;
    673667}
    … …  
    681675    height: 0;
    682676    overflow: hidden;
    683     -webkit-transform: translateX(-100%);
    684677    transform: translateX(-100%);
    685678}
    … …  
    10761069    z-index: 10;
    10771070    background: #eee;
    1078     display: -webkit-box;
    10791071    display: flex;
    10801072}
    … …  
    10881080#available-menu-items .new-content-item .create-item-input,
    10891081.customize-control-dropdown-pages .new-content-item .create-item-input {
    1090     -webkit-box-flex: 10;
    10911082    flex-grow: 10;
    10921083}
    … …  
    10951086.customize-control-dropdown-pages .new-content-item .add-content {
    10961087    margin: 2px 0 2px 6px;
    1097     -webkit-box-flex: 10;
    10981088    flex-grow: 1;
    10991089}
    … …  
    12161206}
    12171207
    1218 @-webkit-keyframes customize-fade-in {
    1219     0%   { opacity: 0; }
    1220     100% { opacity: 1; }
    1221 }
    1222 
    12231208@keyframes customize-fade-in {
    12241209    0%   { opacity: 0; }
    … …  
    12331218
    12341219#customize-controls .customize-control-notifications-container.has-overlay-notifications {
    1235     -webkit-animation: customize-fade-in 0.5s;
    12361220    animation: customize-fade-in 0.5s;
    12371221    z-index: 30;
    … …  
    15071491.customize-control-header .placeholder:hover .dice,
    15081492.customize-control-header .header-view:hover > button.random .dice {
    1509     -webkit-animation: dice-color-change 3s infinite;
    15101493    animation: dice-color-change 3s infinite;
    15111494}
    15121495
    15131496.button-see-me {
    1514     -webkit-animation: bounce .7s 1;
    15151497    animation: bounce .7s 1;
    1516     -webkit-transform-origin: center bottom;
    15171498    transform-origin: center bottom;
    1518 }
    1519 
    1520 @-webkit-keyframes bounce {
    1521     from, 20%, 53%, 80%, to {
    1522         -webkit-animation-timing-function: cubic-bezier(0.215, 0.610, 0.355, 1.000);
    1523         -webkit-transform: translate3d(0,0,0);
    1524     }
    1525 
    1526     40%, 43% {
    1527         -webkit-animation-timing-function: cubic-bezier(0.755, 0.050, 0.855, 0.060);
    1528         -webkit-transform: translate3d(0, -12px, 0);
    1529     }
    1530 
    1531     70% {
    1532         -webkit-animation-timing-function: cubic-bezier(0.755, 0.050, 0.855, 0.060);
    1533         -webkit-transform: translate3d(0, -6px, 0);
    1534     }
    1535 
    1536     90% {
    1537         -webkit-transform: translate3d(0,-1px,0);
    1538     }
    15391499}
    15401500
    15411501@keyframes bounce {
    15421502    from, 20%, 53%, 80%, to {
    1543         -webkit-animation-timing-function: cubic-bezier(0.215, 0.610, 0.355, 1.000);
    15441503        animation-timing-function: cubic-bezier(0.215, 0.610, 0.355, 1.000);
    1545         -webkit-transform: translate3d(0,0,0);
    15461504        transform: translate3d(0,0,0);
    15471505    }
    15481506
    15491507    40%, 43% {
    1550         -webkit-animation-timing-function: cubic-bezier(0.755, 0.050, 0.855, 0.060);
    15511508        animation-timing-function: cubic-bezier(0.755, 0.050, 0.855, 0.060);
    1552         -webkit-transform: translate3d(0, -12px, 0);
    15531509        transform: translate3d(0, -12px, 0);
    15541510    }
    15551511
    15561512    70% {
    1557         -webkit-animation-timing-function: cubic-bezier(0.755, 0.050, 0.855, 0.060);
    15581513        animation-timing-function: cubic-bezier(0.755, 0.050, 0.855, 0.060);
    1559         -webkit-transform: translate3d(0, -6px, 0);
    15601514        transform: translate3d(0, -6px, 0);
    15611515    }
    15621516
    15631517    90% {
    1564         -webkit-transform: translate3d(0,-1px,0);
    15651518        transform: translate3d(0,-1px,0);
    15661519    }
    … …  
    18321785    border-color: #999;
    18331786    box-shadow: inset 0 2px 5px -3px rgba( 0, 0, 0, 0.5 );
    1834     -webkit-transform: translateY(1px);
    18351787    transform: translateY(1px);
    18361788}
    … …  
    18611813
    18621814/* Adds a delay before fading in to avoid it "jumping" */
    1863 @-webkit-keyframes themes-fade-in {
    1864     0% {
    1865         opacity: 0;
    1866     }
    1867     50% {
    1868         opacity: 0;
    1869     }
    1870     100% {
    1871         opacity: 1;
    1872     }
    1873 }
    18741815@keyframes themes-fade-in {
    18751816    0% {
    … …  
    18851826
    18861827.control-panel-themes .customize-themes-full-container.animate {
    1887     -webkit-animation: .6s themes-fade-in 1;
    18881828    animation: .6s themes-fade-in 1;
    18891829}
    18901830
    18911831.in-themes-panel:not(.animating) .control-panel-themes .filter-themes-count {
    1892     -webkit-animation: .6s themes-fade-in 1;
    18931832    animation: .6s themes-fade-in 1;
    18941833}
    … …  
    25762515.adding-menu-items .add-new-menu-item:before,
    25772516#accordion-section-add_menu .add-new-menu-item.open:before {
    2578     -webkit-transform: rotate(45deg);
    25792517    transform: rotate(45deg);
    25802518}
Note: See TracChangeset for help on using the changeset viewer.