Changeset 43309 for trunk/src/wp-admin/css/about.css

Timestamp:

05/23/2018 10:04:22 AM (8 years ago)

Author:

pento

Message:

Once upon a midnight dreary, while I coded, weak and weary,
In many a strange and curious file of forgotten lore—
While I pondered, blaming Nacin, my notifications suddenly awakened,
As of someone quietly DMing;—DMing me, I can’t ignore.
“’Tis some contributor,” I muttered, “DMing me an idea or four—

Only this and nothing more.”

Ah, distinctly I remember, at WordCamp US, last December;
A mad proposal nearly laid me—down out cold—upon the floor.
Curious, I listened closely;—to a plan I agreed with, mostly—
A way to make our JavaScript—JavaScript which was a chore—
Maintainable, extendable, for the future, is what I saw.

Guten-ready for evermore.

Open here I switch to Slack, when, with many a patch and hack,
In there stepped Omar, a JavaScript developer hardcore;
Pronouncing all the changes fit; ready now to be commit;
“There’s nothing else for us to do,” DMing me, “It’s done!” he swore—
“No longer random guessing at which file need next be explored—

Let’s move on, we’re all aboard.”

Moved all together, grouped and managed, in folders all is packaged,
The code had all been cleaned and tidied, important parts moved to the fore,
“Though this change be useful here,” I said, “it is too large, I fear,
We couldn’t manage such a patch, we’ve done nothing like this before—
Tell me where doth go this change, change to make our codebase soar!”

Quoth Omar, “In WordPress Core.”

Props omarreis for shepherding this significant change.
Props adamsilverstein, aduth, atimmer, dingo_bastard, frank-klein, gziolo, herregroen, jaswrks, jeremyfelt, jipmoors, jorbin, netweb, ocean90, pento, tjnowell, and youknowriad for testing, feedback, discussion, encouragement, commiserations, etc.
I make no apologies for this commit message.
Fixes #43055.

File:

• trunk/src/wp-admin/css/about.css (modified) (6 diffs)

trunk/src/wp-admin/css/about.css

@@ -169 +169 @@
 
 .about-wrap [class$="-col"] {
-    display: -webkit-box;
     display: flex;
-    -webkit-box-pack: justify;
     justify-content: space-between;
     flex-wrap: wrap;
@@ -192 +190 @@
 
 .about-wrap [class$="-col"] .col {
-    -webkit-box-flex: 1;
     flex: 1;
 }
@@ -202 +199 @@
 
 .about-wrap .three-col .col {
-    -webkit-align-self: flex-start;
     align-self: flex-start;
     min-width: 31%;
@@ -382 +378 @@
     -ms-grid-column: 2;
     grid-column: 2;
-    display: -webkit-box;
     display: flex;
-    -webkit-box-pack: justify;
     justify-content: space-between;
-    -webkit-box-align: start;
     align-items: flex-start;
-    -webkit-box-orient: horizontal;
-    -webkit-box-direction: normal;
     flex-flow: row wrap;
-    -webkit-box-flex: 2;
     flex-grow: 2;
     flex-shrink: 0;
@@ -397 +387 @@
 
 .about-wrap .floating-header-section .section-item {
-    -webkit-box-flex: 1;
     flex-grow: 1;
     max-width: calc(50% - 30px);
@@ -426 +415 @@
 
 .about-wrap .floating-header-section.has-long-title .section-content {
-    -webkit-box-pack: start;
     justify-content: flex-start;
 }