lexical_sept_2026 #6212

Closed

Chinmay_21 wants to merge 0 commits from lexical_sept_2026 into l10n_development

pull from: lexical_sept_2026

merge into: bookstack:l10n_development

bookstack:development

bookstack:l10n_development

bookstack:release

bookstack:v26-05-branch

bookstack:progress_indicator

bookstack:snyk-action

bookstack:ci_and_static

bookstack:mfa_key

bookstack:phpstan_june26

bookstack:llm_only

bookstack:vectors

bookstack:captcha_example

Conversation 1 Commits - Files changed - +603 -85

Chinmay_21 commented 2026-09-13 10:21:10 +02:00

First-time contributor

Copy link

Details

Fixes #6208.

This PR addresses an issue where saving a BookStack page containing certain special characters formatted as inline code results in a 403 Forbidden error.

The issue was encountered while creating documentation about illegal file-name characters, where the characters were included as inline code.

The expected behaviour is that the page should save normally when these characters are included as legitimate page content.

## Details Fixes #6208. This PR addresses an issue where saving a BookStack page containing certain special characters formatted as inline code results in a `403 Forbidden` error. The issue was encountered while creating documentation about illegal file-name characters, where the characters were included as inline code. The expected behaviour is that the page should save normally when these characters are included as legitimate page content.

Chinmay_21 added 14 commits 2026-09-13 10:21:11 +02:00

Lexical: Fixed re-focus after modal in some cases ... 4d5e9fc8c4

Updated code editor display so the editor area actually gains focus
again.
Updated modal handling to delegate focus handling to the editor if focus
was on the edit area before, to prevent cursor jumps to the start.

Lexical: Added missing code block direction handling ... 74e271c639

Adds some base text direction handling to decorator nodes which can be
used by nodes where it makes sense, like for the code block node.

Lexical: Added enter/shift+enter handling for images in list items ... e573d2458b

Added testing to cover

Lexical: Fixed formatting on reverse selection ranges in lists ... 9b56295dfd

Block formatting on range selection could break when made from bottom to
top, due to using the first selected for insertion position instead of
the first in the doc structure.

Lexical: Made callout formatting in lists more reliable ... df40d8c08a

Updates the callout toggle action to consider callouts in lists (and
other callouts) when making changes.

Lexical: Fixed difference in line break in-editor & on export ... f8c2ada021

Aligned the linebreak exportdom behaviour to align with how the
reconciler displays line breaks in the editor, by adding an extra line
break to each series of line breaks, so they're now visually the same
across editor and export.

Lexical: Added clipboard/drag handling for single nodes ... e08f11d6ff

Fixes behaviour when using cut/copy/drag for items like images or code
blocks.

Also updates history handling to not ignore additions where original
content remains unchanged.

Lexical: Updated pop up form fields to be wider ... bb76d14f82

Better matches the old editor, and makes long input data like URLs more
usable.

Lexical: Fixed modals closing on clicks starting from within modals ... ff9755a32d

Specifically on chromium browsers. Firefox was fine before.
Changes tested across both.

Lexical: Set details node as a shadow root ... 88e7748621

Fixes issues with list creation inside details elements.

Lexical: Fixed ability to cut/copy/drag+drop details nodes ... 1902a291b3

Required updating the selection management to ensure they are selected
upon mousedown, for when a drag operation starts.
Also added draggable management, which we have to avoid having there
when open unless a drag is started, otherwise contents are not editable
in chromium browsers.

Lexical: Prevented link entity selector overwriting existing link text ... b869c6a78e

It now retains existing input where set.
This also updates the modal click handling with an extra click source
check to handle cases where a mousedown event is not emitted, like on
select list dismissals.

Lexical: Fixed node resizer not reacting to content size changes 17f5e9bfa7

JS: Fixed failing test after lexical changes 1498c2fa35

danb commented 2026-09-13 14:19:30 +02:00

Owner

Copy link

Hi @Chinmay_21,

Like with #6211, Not sure if something has gone wrong here.
This does again not address #6208, but is just a PR for my changes from another branch/PR.

Will therefore close this off.

Hi @Chinmay_21, Like with #6211, Not sure if something has gone wrong here. This does again not address #6208, but is just a PR for my changes from another branch/PR. Will therefore close this off.

danb closed this pull request 2026-09-13 14:19:31 +02:00

All checks were successful

Hide checks

test-js / build (push) Successful in 1m8s

Details

test-js / build (pull_request) Successful in 40s

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Focus: A11y

Accessibility

  

Focus: Admin/Meta

  

Focus: Authentication

  

Focus: Back-End

  

Focus: Database

  

Focus: Design & UX

  

Focus: Editor - Markdown

  

Focus: Editor - WYSIWYG

  

Focus: Export System

  

Focus: Front-End

  

Focus: Translations

  

Focus: View Customization

  

Is: Docs Update

  

Is: Enhancement

  

Is: Priority

  

Is: Security

  

Is: Upstream

  

Status

Blocked

  

Status

Open to discussion

  

Status

Out of scope

  

Status

Pending Validation

  

Type

API Request

  

Type

Bug Report

  

Type

Feature Request

  

Type

Happy feedback

  

Type

Maintenance

  

Type

Question

  

Type

Support

No labels

Focus: A11y

Focus: Admin/Meta

Focus: Authentication

Focus: Back-End

Focus: Database

Focus: Design & UX

Focus: Editor - Markdown

Focus: Editor - WYSIWYG

Focus: Export System

Focus: Front-End

Focus: Translations

Focus: View Customization

Is: Docs Update

Is: Enhancement

Is: Priority

Is: Security

Is: Upstream

Status

Blocked

Status

Open to discussion

Status

Out of scope

Status

Pending Validation

Type

API Request

Type

Bug Report

Type

Feature Request

Type

Happy feedback

Type

Maintenance

Type

Question

Type

Support

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

bookstack/bookstack!6212

No description provided.