bookstack/bookstack
bookstack/bookstack
Watch
44
261
Fork
You've already forked bookstack
 32
Code Issues 698 Pull requests 8 Releases 240 Activity Actions 26

Lexical fixes for v26.09 #6207

Merged
danb merged 14 commits from lexical_sept_2026 into development 2026-09-13 23:12:57 +02:00
Conversation 0 Commits 14 Files changed 28 +603 -85
danb commented 2026-09-03 19:54:06 +02:00
Owner
Copy link

For #6130

  • Updated code editor display so the editor area actually gains focus again.
  • Updated modal handling to delegate focus handling to the editor if focus was on the edit area before, to prevent cursor jumps to the start.
  • Fixed lack of text direction handling for code blocks.
  • Updated enter/shift-enter handling for images when used directly in lists.
  • Fixed formatting on reverse selection ranges in lists.
  • Updated callout formatting shortcut handling, when in lists, to be more reliable.
  • Fixed difference in line break in-editor & on export, preventing line breaks being removed on save.
  • Updated copy/cut/paste/drag logic to specifically handle single selectable blocks like images/media.
  • Updated pop up form fields to be wider for easier use and to match old editor.
  • Fixed modals closing on out-of-window clicks, which are started from within the modal, on Chromium browsers.
  • Updated collapsible blocks to be shadow root nodes, fixing issues with creating lists inside them.
  • Fixed ability to cut/copy/drag+drop details nodes.
  • Fixed issue where link editor entity selection would overwrite existing link text/title.
  • Fixed image node resizer not reacting to size changes.
For #6130 - Updated code editor display so the editor area actually gains focus again. - Updated modal handling to delegate focus handling to the editor if focus was on the edit area before, to prevent cursor jumps to the start. - Fixed lack of text direction handling for code blocks. - Updated enter/shift-enter handling for images when used directly in lists. - Fixed formatting on reverse selection ranges in lists. - Updated callout formatting shortcut handling, when in lists, to be more reliable. - Fixed difference in line break in-editor & on export, preventing line breaks being removed on save. - Updated copy/cut/paste/drag logic to specifically handle single selectable blocks like images/media. - Updated pop up form fields to be wider for easier use and to match old editor. - Fixed modals closing on out-of-window clicks, which are started from within the modal, on Chromium browsers. - Updated collapsible blocks to be shadow root nodes, fixing issues with creating lists inside them. - Fixed ability to cut/copy/drag+drop details nodes. - Fixed issue where link editor entity selection would overwrite existing link text/title. - Fixed image node resizer not reacting to size changes.
danb added this to the v26.09 milestone 2026-09-03 19:54:06 +02:00
Lexical: Fixed re-focus after modal in some cases
All checks were successful
test-js / build (push) Successful in 1m11s
Details
test-js / build (pull_request) Successful in 30s
Details
4d5e9fc8c4
 
Updated code editor display so the editor area actually gains focus
again.
Updated modal handling to delegate focus handling to the editor if focus
was on the edit area before, to prevent cursor jumps to the start.
danb self-assigned this 2026-09-03 19:54:12 +02:00
Lexical: Added missing code block direction handling
All checks were successful
test-js / build (pull_request) Successful in 30s
Details
test-js / build (push) Successful in 1m19s
Details
74e271c639
 
Adds some base text direction handling to decorator nodes which can be
used by nodes where it makes sense, like for the code block node.
Lexical: Added enter/shift+enter handling for images in list items
All checks were successful
test-js / build (pull_request) Successful in 36s
Details
test-js / build (push) Successful in 38s
Details
e573d2458b
 
Added testing to cover
Block formatting on range selection could break when made from bottom to
top, due to using the first selected for insertion position instead of
the first in the doc structure.
Lexical: Made callout formatting in lists more reliable
All checks were successful
test-js / build (pull_request) Successful in 32s
Details
test-js / build (push) Successful in 1m3s
Details
df40d8c08a
 
Updates the callout toggle action to consider callouts in lists (and
other callouts) when making changes.
Lexical: Fixed difference in line break in-editor & on export
All checks were successful
test-js / build (pull_request) Successful in 33s
Details
test-js / build (push) Successful in 1m5s
Details
f8c2ada021
 
Aligned the linebreak exportdom behaviour to align with how the
reconciler displays line breaks in the editor, by adding an extra line
break to each series of line breaks, so they're now visually the same
across editor and export.
Lexical: Added clipboard/drag handling for single nodes
All checks were successful
test-js / build (pull_request) Successful in 32s
Details
test-js / build (push) Successful in 1m7s
Details
e08f11d6ff
 
Fixes behaviour when using cut/copy/drag for items like images or code
blocks.

Also updates history handling to not ignore additions where original
content remains unchanged.
Lexical: Updated pop up form fields to be wider
All checks were successful
test-js / build (pull_request) Successful in 1m22s
Details
bb76d14f82
 
Better matches the old editor, and makes long input data like URLs more
usable.
Lexical: Fixed modals closing on clicks starting from within modals
All checks were successful
test-js / build (pull_request) Successful in 32s
Details
test-js / build (push) Successful in 1m7s
Details
ff9755a32d
 
Specifically on chromium browsers. Firefox was fine before.
Changes tested across both.
Lexical: Set details node as a shadow root
All checks were successful
test-js / build (push) Successful in 33s
Details
test-js / build (pull_request) Successful in 1m12s
Details
88e7748621
 
Fixes issues with list creation inside details elements.
Lexical: Fixed ability to cut/copy/drag+drop details nodes
Some checks failed
test-js / build (pull_request) Failing after 32s
Details
test-js / build (push) Failing after 1m7s
Details
1902a291b3
 
Required updating the selection management to ensure they are selected
upon mousedown, for when a drag operation starts.
Also added draggable management, which we have to avoid having there
when open unless a drag is started, otherwise contents are not editable
in chromium browsers.
Lexical: Prevented link entity selector overwriting existing link text
Some checks failed
test-js / build (pull_request) Failing after 32s
Details
test-js / build (push) Failing after 1m7s
Details
b869c6a78e
 
It now retains existing input where set.
This also updates the modal click handling with an extra click source
check to handle cases where a mousedown event is not emitted, like on
select list dismissals.
Lexical: Fixed node resizer not reacting to content size changes
Some checks failed
test-js / build (pull_request) Failing after 32s
Details
test-js / build (push) Failing after 1m7s
Details
17f5e9bfa7
JS: Fixed failing test after lexical changes
All checks were successful
test-js / build (push) Successful in 1m8s
Details
test-js / build (pull_request) Successful in 40s
Details
1498c2fa35
danb merged commit 5969afcbdb into development 2026-09-13 23:12:57 +02:00
danb deleted branch lexical_sept_2026 2026-09-13 23:13:00 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Focus: A11y
Accessibility

  
Focus: Admin/Meta

   
Focus: Authentication

   
Focus: Back-End

   
Focus: Database

   
Focus: Design & UX

   
Focus: Editor - Markdown

   
Focus: Editor - WYSIWYG

   
Focus: Export System

   
Focus: Front-End

   
Focus: Translations

   
Focus: View Customization

   
Is: Docs Update

   
Is: Enhancement

   
Is: Priority

   
Is: Security

   
Is: Upstream
  
Status
Blocked

  
Status
Open to discussion

  
Status
Out of scope

  
Status
Pending Validation

  
Type
API Request

  
Type
Bug Report

  
Type
Feature Request

  
Type
Happy feedback

  
Type
Maintenance

  
Type
Question

  
Type
Support

No labels
Focus: A11y
Focus: Admin/Meta
Focus: Authentication
Focus: Back-End
Focus: Database
Focus: Design & UX
Focus: Editor - Markdown
Focus: Editor - WYSIWYG
Focus: Export System
Focus: Front-End
Focus: Translations
Focus: View Customization
Is: Docs Update
Is: Enhancement
Is: Priority
Is: Security
Is: Upstream
Status
Blocked
Status
Open to discussion
Status
Out of scope
Status
Pending Validation
Type
API Request
Type
Bug Report
Type
Feature Request
Type
Happy feedback
Type
Maintenance
Type
Question
Type
Support
Milestone
Clear milestone
No items
No milestone
v26.09
Assignees
Clear assignees
No assignees
danb
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
bookstack/bookstack!6207
No description provided.