bookstack/bookstack

Fork 12

Add support for HS256 ODIC #6110

Open

MilnerMart wants to merge 2 commits from MilnerMart/development into development

MilnerMart commented

2026-04-20 18:59:04 +02:00

(Migrated from github.com)

Summary

This pull request adds the ability to accept other token signing algorithms, especially HS256, but with the possibility of extending to other algorithms as needed.

Checklist

I have read the BookStack community rules.
This PR does not feature significant use of LLM/AI generation as per the community rules above.

Summary This pull request adds the ability to accept other token signing algorithms, especially HS256, but with the possibility of extending to other algorithms as needed. ## Checklist  - [X] I have read the [BookStack community rules](https://www.bookstackapp.com/about/community-rules/). - [X] This PR does not feature significant use of LLM/AI generation as per the community rules above.

ssddanbrown commented

2026-04-21 18:55:40 +02:00

(Migrated from github.com)

Thanks for offering this @MilnerMart, but there's already an existing request to support addition signing options in #5912. This is blocked though as I feel we need to define where our bounds of support lie as my comment in https://github.com/BookStackApp/BookStack/issues/5390#issuecomment-3567922489.
Feel free to provide input on #5390 in regard to the draft criteria, or even open a feature request issue to specifically request HS256 support.

Thanks for offering this @MilnerMart, but there's already an existing request to support addition signing options in #5912. This is blocked though as I feel we need to define where our bounds of support lie as my comment in https://github.com/BookStackApp/BookStack/issues/5390#issuecomment-3567922489. Feel free to provide input on #5390 in regard to the draft criteria, or even open a feature request issue to specifically request HS256 support.

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin MilnerMart/development:MilnerMart/development

git switch MilnerMart/development

Merge

Merge the changes and update on Forgejo.

git switch development

git merge --no-ff MilnerMart/development

git switch MilnerMart/development

git rebase development

git switch development

git merge --ff-only MilnerMart/development

git switch MilnerMart/development

git rebase development

git switch development

git merge --no-ff MilnerMart/development

git switch development

git merge --squash MilnerMart/development

git switch development

git merge --ff-only MilnerMart/development

git switch development

git merge MilnerMart/development

git push origin development

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

bookstack/bookstack!6110

No description provided.

Rows
Columns