Page previews failing for pages that begin with included content #442

New issue

Closed

opened 2017-07-18 16:40:17 +02:00 by XtremeBain · 1 comment

XtremeBain commented

2017-07-18 16:40:17 +02:00

(Migrated from github.com)

For Bug Reports

BookStack Version: v0.17.1
PHP Version: 7.0.15
MySQL Version: 5.7.17

Expected Behavior

The chapter page which lists pages with their previews should properly render the preview for pages that have included content in the beginning of them.

Actual Behavior

On the main page of a chapter that lists all of a chapter's pages, if a page's preview contains an include tag for another page or bookmark, there is a javascript TypeError exception logged to the console and the page list does not render.

### For Bug Reports * BookStack Version: v0.17.1 * PHP Version: 7.0.15 * MySQL Version: 5.7.17 ##### Expected Behavior The chapter page which lists pages with their previews should properly render the preview for pages that have included content in the beginning of them. ##### Actual Behavior On the main page of a chapter that lists all of a chapter's pages, if a page's preview contains an include tag for another page or bookmark, there is a javascript TypeError exception logged to the console and the page list does not render.

ssddanbrown commented

2017-07-22 15:25:57 +02:00

(Migrated from github.com)

@XtremeBain Thanks for reporting, Will be in the next bugfix release.

I've updated it so included content is parsed into the text view for list previews and searching. This is only on save though (For performance reasons) so it is possible that this text content may become outdated if the included content is changed.

@XtremeBain Thanks for reporting, Will be in the next bugfix release. I've updated it so included content is parsed into the text view for list previews and searching. This is only on save though (For performance reasons) so it is possible that this text content may become outdated if the included content is changed.

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

bookstack/bookstack#442

No description provided.

Rows
Columns