bookstack/api-scripts
2
5
Fork 5
Code Issues Pull requests Activity

Added PDF conversion capabilities and simplified conversion script #17

Closed
InputObject2 wants to merge 1 commit from main into main
pull from: main
merge into: bookstack:main
Conversation 1 Commits 1 Files changed 4 +540 -214
InputObject2 commented 2024-03-28 21:37:01 +01:00 (Migrated from github.com)
Copy link

I ended up reworking the original script quite a bit since I wanted to put the different functions on their own to simplify adding more parsers in the future if needed.

I also added a java check since pdf2html requires java to be in the path to be able to run the .jar for conversion.

There's also some logging on import.

I'm planning to add another modification to this script to parse a folder (if that's what is provided instead of a file name) and upload all the supported files it finds in it.

I ended up reworking the original script quite a bit since I wanted to put the different functions on their own to simplify adding more parsers in the future if needed. I also added a java check since pdf2html requires java to be in the path to be able to run the .jar for conversion. There's also some logging on import. I'm planning to add another modification to this script to parse a folder (if that's what is provided instead of a file name) and upload all the supported files it finds in it.
ssddanbrown commented 2024-03-28 21:56:50 +01:00 (Migrated from github.com)
Copy link

Thanks for offering these changes @InputObject2 but I'm not really looking to increase the scope or functionality of these scripts much wider to keep maintenance reasonable, they're really here to provide some simple starting points or examples for various scenarios.

Feel free though to extract your more developed work into it's own repository for it to then be added to the "Community Projects & Scripts" list in the project readme.

Thanks for offering these changes @InputObject2 but I'm not really looking to increase the scope or functionality of these scripts much wider to keep maintenance reasonable, they're really here to provide some simple starting points or examples for various scenarios. Feel free though to extract your more developed work into it's own repository for it to then be added to the "Community Projects & Scripts" list in the project readme.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
bookstack/api-scripts!17
No description provided.