Changeset 29646

Timestamp:

10/14/2014 02:17:18 AM (11 years ago)

Author:

boonebgorges

Message:

Use only LEFT JOINs when a meta_query contains a NOT EXISTS clause.

Mixing LEFT and INNER JOIN in these cases results in posts with no metadata
being improperly excluded from results.

Props johnrom.
Fixes #29062.
Built from ​https://develop.svn.wordpress.org/trunk@29890

File:

• trunk/wp-includes/meta.php (modified) (1 diff)

trunk/wp-includes/meta.php

@@ -1123 +1123 @@
 
         $sql = $this->get_sql_clauses();
+
+        /*
+         * If any JOINs are LEFT JOINs (as in the case of NOT EXISTS), then all JOINs should
+         * be LEFT. Otherwise posts with no metadata will be excluded from results.
+         */
+        if ( false !== strpos( $sql['join'], 'LEFT JOIN' ) ) {
+            $sql['join'] = str_replace( 'INNER JOIN', 'LEFT JOIN', $sql['join'] );
+        }
 
         /**