> I think checking code validness is hard I agree, since this check happens during lexical analysis, rather than parsing. It is a bit mind-boggling to me that lexical analysis depends on local variable scope, but it's what it is. I ten...jneen (Jeanine Adkisson)
I should say that I think the *worst* solution to this would be to warn in both cases. It would effectively require us to rewrite our DSL across every rule for every language we support. My ideal world is one where we could go back to us...jneen (Jeanine Adkisson)
That was my expectation as well, but what I observed was that it does in fact seem to preserve warning behaviour for all of the other cases discussed here, as noted both here and in the pull request description. I would definitely feel s...jneen (Jeanine Adkisson)
As a point of order - I opened a pull request against Onigmo, should that have been to Ruby instead? I'm happy to do either or both. It is a fairly simple fix, but there are some tests in Ruby main that would need to change to reflect th...jneen (Jeanine Adkisson)
I have submitted a patch to Onigmo with the naive strategy (A) as outlined above: https://github.com/k-takata/Onigmo/pull/175 Contrary to my expectations, it does appear that `/[\p{Word}\p{Alpha}]/` and `/[a-fb-g]/` **do** continue...jneen (Jeanine Adkisson)
* [Bug #21870] Regexp: Warnings when using slightly overlapping `\p{...}` classes (jneen) * Warning spam on code that definitely isn't a mistake (`/[\p{Word}\p{S}]/` and other overlapping properties) * Noted some possible ways forwar...jneen (Jeanine Adkisson)
If there are no objections, I'll submit a patch with strategy (a) next week. It's straightforward to implement and maintains the closest to the current behaviour as possible while fixing the issue.jneen (Jeanine Adkisson)
Having looked through the onigmo code a bit now, I can think of a few ways forward. **a) Simply don't warn on overlapping ctype classes.** I believe this would only involve removing the check on line 1860 from regparse.c. This woul...jneen (Jeanine Adkisson)