Changeset 14178

Timestamp:

12/27/2025 01:40:05 AM (3 months ago)

Author:

espellcaste

Message:

When the Extended Profiles component is disabled, the "Profile Visibility" settings link does not 404.

The "Profile Visibility" link, members/user/settings/profile/, relies on the Extended Profiles component to work properly. When this component is disabled, the link should not added to the user profile settings menu.

We also did the same for the Email link. So that it is added only when the Notifications component is enabled.

Developed at ​https://github.com/buddypress/buddypress/pull/414/

Props joelkarunungan, nikunj8866, and vapvarun.

See #9297 (14.0)

File:

• branches/14.0/src/bp-settings/classes/class-bp-settings-component.php (modified) (1 diff)

branches/14.0/src/bp-settings/classes/class-bp-settings-component.php

@@ -155 +155 @@
         );
 
-        // Add Email nav item. Formerly called 'Notifications', we
-        // retain the old slug and function names for backward compat.
-        $sub_nav[] = array(
-            'name'                     => __( 'Email', 'buddypress' ),
-            'slug'                     => 'notifications',
-            'parent_slug'              => $slug,
-            'screen_function'          => 'bp_settings_screen_notification',
-            'position'                 => 20,
-            'user_has_access'          => false,
-            'user_has_access_callback' => 'bp_core_can_edit_settings',
-        );
-
-        $sub_nav[] = array(
-            'name'                     => _x( 'Profile Visibility', 'Profile settings sub nav', 'buddypress' ),
-            'slug'                     => 'profile',
-            'parent_slug'              => $slug,
-            'screen_function'          => 'bp_xprofile_screen_settings',
-            'position'                 => 30,
-            'user_has_access'          => false,
-            'user_has_access_callback' => 'bp_core_can_edit_settings',
-        );
+        /**
+         * Add Email nav item. Formely called 'Notifications', we
+         * retain the old slug and function names for backward compat.
+         */
+        if ( bp_is_active( 'notifications' ) ) {
+            $sub_nav[] = array(
+                'name'                     => __( 'Email', 'buddypress' ),
+                'slug'                     => 'notifications',
+                'parent_slug'              => $slug,
+                'screen_function'          => 'bp_settings_screen_notification',
+                'position'                 => 20,
+                'user_has_access'          => false,
+                'user_has_access_callback' => 'bp_core_can_edit_settings',
+            );
+        }
+
+        if ( bp_is_active( 'xprofile' ) ) {
+            $sub_nav[] = array(
+                'name'                     => _x( 'Profile Visibility', 'Profile settings sub nav', 'buddypress' ),
+                'slug'                     => 'profile',
+                'parent_slug'              => $slug,
+                'screen_function'          => 'bp_xprofile_screen_settings',
+                'position'                 => 30,
+                'user_has_access'          => false,
+                'user_has_access_callback' => 'bp_core_can_edit_settings',
+            );
+        }
 
         $sub_nav[] = array(