Changeset 7397

Timestamp:

02/18/2026 06:49:42 PM (5 weeks ago)

Author:

johnjamesjacoby

Message:

Common: Fix incorrect encoding in bbp_is_title_too_long().

This commit changes the way that Forum/Topic/Reply title lengths are calculated, away from 8bit for counting bytes to utf-8 for counting characters.

This change is necessary to allow unicode (multibyte) characters to be more accurately included in the overall length calculation, to better match the intention for this optional limitation.

In trunk, for 2.7.

Props r-a-y.

Fixes #3664.

File:

• trunk/src/includes/common/functions.php (modified) (2 diffs)

trunk/src/includes/common/functions.php

@@ -2805 +2805 @@
  * Is a title longer that the maximum title length?
  *
- * Uses mb_strlen() in `8bit` mode to treat strings as raw. This matches the
- * behavior present in Comments, PHPMailer, RandomCompat, and others.
+ * Uses mb_strlen() in `utf-8` mode to treat strings as is. This differs from
+ * the behavior present in Comments, PHPMailer, RandomCompat, and others,
+ * because the database column used by titles (posts.post_title) is
+ * TEXT (characters) and not VARCHAR (bytes).
  *
  * @since 2.6.0 bbPress (r6783)
@@ -2815 +2817 @@
 function bbp_is_title_too_long( $title = '' ) {
     $max    = bbp_get_title_max_length();
-    $len    = mb_strlen( $title, '8bit' );
+    $len    = mb_strlen( $title, 'utf-8' );
     $result = ( $len > $max );