Changeset 7129

Timestamp:

08/12/2020 07:11:47 PM (5 years ago)

Author:

johnjamesjacoby

Message:

Akismet: fix spam check not sending author info for logged in users

This commit uses bbp_has_errors() to catch whether anonymous information exists or not, and falls back to the currently logged in user otherwise (anonymous has priority due to moderator ability to edit topics & replies).

This commit also improves the readability of a few lengthy function calls, and adds empty() checks to all of the related array key touches.

In trunk, for 2.7.

Props procifer.

See #3368.

File:

• trunk/src/includes/extend/akismet.php (modified) (5 diffs)

trunk/src/includes/extend/akismet.php

@@ -80 +80 @@
      * @since 2.0.0 bbPress (r3277)
      *
-     * @param string $post_data
+     * @param array $post_data
      *
      * @return array Array of post data
      */
-    public function check_post( $post_data ) {
+    public function check_post( $post_data = array() ) {
 
         // Define local variables
@@ -111 +111 @@
 
         // Author is anonymous
-        if ( ! empty( $anonymous_data ) ) {
+        if ( ! bbp_has_errors() ) {
             $user_data['name']    = $anonymous_data['bbp_anonymous_name'];
             $user_data['email']   = $anonymous_data['bbp_anonymous_email'];
@@ -525 +525 @@
 
         // Set up Akismet last post data
-        if ( ! empty( $this->last_post ) ) {
+        if ( ! empty( $this->last_post['bbp_post_as_submitted'] ) ) {
             $as_submitted = $this->last_post['bbp_post_as_submitted'];
         }
@@ -537 +537 @@
             $anonymous_data = bbp_filter_anonymous_post_data();
 
+            // Which name?
+            $name = ! empty( $anonymous_data['bbp_anonymous_name'] )
+                ? $anonymous_data['bbp_anonymous_name']
+                : $userdata->display_name;
+
+            // Which email?
+            $email = ! empty( $anonymous_data['bbp_anonymous_email'] )
+                ? $anonymous_data['bbp_anonymous_email']
+                : $userdata->user_email;
+
             // More checks
-            if (    intval( $as_submitted['comment_post_ID'] )    === intval( $_post->post_parent )
-                    &&      $as_submitted['comment_author']       === ( $anonymous_data ? $anonymous_data['bbp_anonymous_name']  : $userdata->display_name )
-                    &&      $as_submitted['comment_author_email'] === ( $anonymous_data ? $anonymous_data['bbp_anonymous_email'] : $userdata->user_email   )
-                ) {
+            if (
+
+                // Post matches
+                ( intval( $as_submitted['comment_post_ID'] ) === intval( $_post->post_parent ) )
+
+                &&
+
+                // Name matches
+                ( $as_submitted['comment_author'] === $name )
+
+                &&
+
+                // Email matches
+                ( $as_submitted['comment_author_email'] === $email )
+            ) {
 
                 // Normal result: true
-                if ( $this->last_post['bbp_akismet_result'] === 'true' ) {
+                if ( ! empty( $this->last_post['bbp_akismet_result'] ) && ( $this->last_post['bbp_akismet_result'] === 'true' ) ) {
 
                     // Leave a trail so other's know what we did
                     update_post_meta( $post_id, '_bbp_akismet_result', 'true' );
-                    $this->update_post_history( $post_id, esc_html__( 'Akismet caught this post as spam', 'bbpress' ), 'check-spam' );
+                    $this->update_post_history(
+                        $post_id,
+                        esc_html__( 'Akismet caught this post as spam', 'bbpress' ),
+                        'check-spam'
+                    );
 
                     // If post_status isn't the spam status, as expected, leave a note
                     if ( bbp_get_spam_status_id() !== $_post->post_status ) {
-                        $this->update_post_history( $post_id, sprintf( esc_html__( 'Post status was changed to %s', 'bbpress' ), $_post->post_status ), 'status-changed-' . $_post->post_status );
+                        $this->update_post_history(
+                            $post_id,
+                            sprintf(
+                                esc_html__( 'Post status was changed to %s', 'bbpress' ),
+                                $_post->post_status
+                            ),
+                            'status-changed-' . $_post->post_status
+                        );
                     }
 
                 // Normal result: false
-                } elseif ( $this->last_post['bbp_akismet_result'] === 'false' ) {
+                } elseif ( ! empty( $this->last_post['bbp_akismet_result'] ) && ( $this->last_post['bbp_akismet_result'] === 'false' ) ) {
 
                     // Leave a trail so other's know what we did
                     update_post_meta( $post_id, '_bbp_akismet_result', 'false' );
-                    $this->update_post_history( $post_id, esc_html__( 'Akismet cleared this post as not spam', 'bbpress' ), 'check-ham' );
+                    $this->update_post_history(
+                        $post_id,
+                        esc_html__( 'Akismet cleared this post as not spam', 'bbpress' ),
+                        'check-ham'
+                    );
 
                     // If post_status is the spam status, which isn't expected, leave a note
                     if ( bbp_get_spam_status_id() === $_post->post_status ) {
-                        $this->update_post_history( $post_id, sprintf( esc_html__( 'Post status was changed to %s', 'bbpress' ), $_post->post_status ), 'status-changed-' . $_post->post_status );
+                        $this->update_post_history(
+                            $post_id,
+                            sprintf(
+                                esc_html__( 'Post status was changed to %s', 'bbpress' ),
+                                $_post->post_status
+                            ),
+                            'status-changed-' . $_post->post_status
+                        );
                     }
 
@@ -571 +614 @@
                     // Leave a trail so other's know what we did
                     update_post_meta( $post_id, '_bbp_akismet_error', time() );
-                    $this->update_post_history( $post_id, sprintf( esc_html__( 'Akismet was unable to check this post (response: %s), will automatically retry again later.', 'bbpress' ), $this->last_post['bbp_akismet_result'] ), 'check-error' );
+                    $this->update_post_history(
+                        $post_id,
+                        sprintf(
+                            esc_html__( 'Akismet was unable to check this post (response: %s), will automatically retry again later.', 'bbpress' ),
+                            $this->last_post['bbp_akismet_result']
+                        ),
+                        'check-error'
+                    );
                 }
 
                 // Record the complete original data as submitted for checking
                 if ( isset( $this->last_post['bbp_post_as_submitted'] ) ) {
-                    update_post_meta( $post_id, '_bbp_akismet_as_submitted', $this->last_post['bbp_post_as_submitted'] );
+                    update_post_meta(
+                        $post_id,
+                        '_bbp_akismet_as_submitted',
+                        $this->last_post['bbp_post_as_submitted']
+                    );
                 }
             }